Use more accurate type for large arraya

Fixes #2690
vimeo · Jan 25, 2020 · 8c89760 · 8c89760
1 parent c3a989f
commit 8c89760
Show file tree

Hide file tree

Showing 2 changed files with 73 additions and 4 deletions.
diff --git a/src/Psalm/Internal/Analyzer/StatementsAnalyzer.php b/src/Psalm/Internal/Analyzer/StatementsAnalyzer.php
@@ -1849,10 +1849,6 @@ public static function getSimpleType(
                     $item_key_type = Type::getInt();
                 }
 
-                if ($item_value_type && !$can_create_objectlike) {
-                    continue;
-                }
-
                 $single_item_value_type = self::getSimpleType(
                     $codebase,
                     $nodes,

diff --git a/tests/ConstantTest.php b/tests/ConstantTest.php
@@ -496,6 +496,79 @@ function test($value): void {
                     const FOO = 1;
                     echo \constant("FOO");'
             ],
+            'tooLongClassConstArray' => [
+                '<?php
+                    class MyTest {
+                        const LOOKUP = [
+                            "A00" => null,
+                            "A01" => null,
+                            "A02" => null,
+                            "A03" => null,
+                            "A04" => null,
+                            "A05" => null,
+                            "A06" => null,
+                            "A07" => null,
+                            "A010" => null,
+                            "A011" => null,
+                            "A012" => null,
+                            "A013" => null,
+                            "A014" => null,
+                            "A015" => null,
+                            "A016" => null,
+                            "A017" => null,
+                            "A020" => null,
+                            "A021" => null,
+                            "A022" => null,
+                            "A023" => null,
+                            "A024" => null,
+                            "A025" => null,
+                            "A026" => null,
+                            "A027" => null,
+                            "A030" => null,
+                            "A031" => null,
+                            "A032" => null,
+                            "A033" => null,
+                            "A034" => null,
+                            "A035" => null,
+                            "A036" => null,
+                            "A037" => null,
+                            "A040" => null,
+                            "A041" => null,
+                            "A042" => null,
+                            "A043" => null,
+                            "A044" => null,
+                            "A045" => null,
+                            "A046" => null,
+                            "A047" => null,
+                            "A050" => null,
+                            "A051" => null,
+                            "A052" => null,
+                            "A053" => null,
+                            "A054" => null,
+                            "A055" => null,
+                            "A056" => null,
+                            "A057" => null,
+                            "A060" => null,
+                            "A061" => null,
+                            "A062" => null,
+                            "A063" => null,
+                            "A064" => self::SUCCEED,
+                            "A065" => self::FAIL,
+                        ];
+
+                        const SUCCEED = "SUCCEED";
+                        const FAIL = "FAIL";
+
+                        /**
+                         * @param string $code
+                         */
+                        public static function will_succeed($code) : bool {
+                            // False positive TypeDoesNotContainType - string(SUCCEED) cannot be identical to null
+                            // This seems to happen because the array has a lot of entries.
+                            return (self::LOOKUP[strtoupper($code)] ?? null) === self::SUCCEED;
+                        }
+                    }'
+            ],
         ];
     }