Only cast in echo when tracking taints

vimeo · Jun 29, 2020 · ab29ac0 · ab29ac0
1 parent cff9760
commit ab29ac0
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/src/Psalm/Internal/Analyzer/Statements/EchoAnalyzer.php b/src/Psalm/Internal/Analyzer/Statements/EchoAnalyzer.php
@@ -37,7 +37,7 @@ public static function analyze(
 
             $expr_type = $statements_analyzer->node_data->getType($expr);
 
-            if ($expr_type) {
+            if ($codebase->taint && $expr_type) {
                 $expr_type = CastAnalyzer::castStringAttempt(
                     $statements_analyzer,
                     $context,

diff --git a/tests/ToStringTest.php b/tests/ToStringTest.php
@@ -161,7 +161,7 @@ public function providerInvalidCodeParse()
                 '<?php
                     class A {}
                     echo (new A);',
-                'error_message' => 'InvalidCast',
+                'error_message' => 'InvalidArgument',
             ],
             'echoCastClass' => [
                 '<?php