Remove redundant flag from SimpleTypeInferer

vimeo · Jan 31, 2022 · e284b91 · e284b91
1 parent 121a801
commit e284b91
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 8 deletions.
diff --git a/src/Psalm/Internal/Analyzer/Statements/Expression/SimpleTypeInferer.php b/src/Psalm/Internal/Analyzer/Statements/Expression/SimpleTypeInferer.php
@@ -55,8 +55,7 @@ public static function infer(
         Aliases $aliases,
         FileSource $file_source = null,
         ?array $existing_class_constants = null,
-        ?string $fq_classlike_name = null,
-        bool $const_inference = false
+        ?string $fq_classlike_name = null
     ): ?Union {
         if ($stmt instanceof PhpParser\Node\Expr\BinaryOp) {
             if ($stmt instanceof PhpParser\Node\Expr\BinaryOp\Concat) {
@@ -432,7 +431,7 @@ public static function infer(
             }
         }
 
-        if ($const_inference && $stmt instanceof PhpParser\Node\Expr\New_) {
+        if ($stmt instanceof PhpParser\Node\Expr\New_) {
             $resolved_class_name = $stmt->class->getAttribute('resolvedName');
 
             if (!is_string($resolved_class_name)) {

diff --git a/src/Psalm/Internal/PhpVisitor/ReflectorVisitor.php b/src/Psalm/Internal/PhpVisitor/ReflectorVisitor.php
@@ -287,11 +287,7 @@ public function enterNode(PhpParser\Node $node): ?int
                     $this->codebase,
                     new NodeDataProvider(),
                     $const->value,
-                    $this->aliases,
-                    null,
-                    null,
-                    null,
-                    true
+                    $this->aliases
                 ) ?? Type::getMixed();
 
                 $fq_const_name = Type::getFQCLNFromString($const->name->name, $this->aliases);