Fix #4958 - honour template as inheritance when comparing template types

vimeo · Jan 9, 2021 · e299e91 · e299e91
1 parent 6ef0f2e
commit e299e91
Show file tree

Hide file tree

Showing 2 changed files with 36 additions and 4 deletions.
diff --git a/src/Psalm/Internal/Type/Comparator/ObjectComparator.php b/src/Psalm/Internal/Type/Comparator/ObjectComparator.php
@@ -73,15 +73,24 @@ public static function isShallowlyContainedBy(
                         continue;
                     }
 
-                    if (\substr($intersection_container_type->defining_class, 0, 3) === 'fn-') {
-                        foreach ($intersection_input_types as $intersection_input_type) {
-                            if ($intersection_input_type instanceof TTemplateParam
-                                && \substr($intersection_input_type->defining_class, 0, 3) === 'fn-'
+                    foreach ($intersection_input_types as $intersection_input_type) {
+                        if ($intersection_input_type instanceof TTemplateParam
+                            && (\substr($intersection_container_type->defining_class, 0, 3) === 'fn-'
+                                || \substr($intersection_input_type->defining_class, 0, 3) === 'fn-')
+                        ) {
+                            if (\substr($intersection_input_type->defining_class, 0, 3) === 'fn-'
+                                && \substr($intersection_container_type->defining_class, 0, 3) === 'fn-'
                                 && $intersection_input_type->defining_class
                                     !== $intersection_container_type->defining_class
                             ) {
                                 continue 2;
                             }
+
+                            foreach ($intersection_input_type->as->getAtomicTypes() as $input_as_atomic) {
+                                if ($input_as_atomic->equals($intersection_container_type)) {
+                                    continue 3;
+                                }
+                            }
                         }
                     }
 

diff --git a/tests/Template/FunctionTemplateTest.php b/tests/Template/FunctionTemplateTest.php
@@ -1485,6 +1485,29 @@ function takesNullableString(string|int $s) : string {
                 [],
                 '8.0'
             ],
+            'templateChildClass' => [
+                '<?php
+                    /** @template T */
+                    class Collection {
+                        /**
+                         * @param T $t
+                         */
+                        private function add($t) : void {}
+
+                        /**
+                         * @template TChild as T
+                         * @param TChild $default
+                         *
+                         * @return TChild
+                         */
+                        public function get($default)
+                        {
+                            $this->add($default);
+
+                            return $default;
+                        }
+                    }'
+            ],
         ];
     }