Merge pull request #7180 from orklah/7178

doesn't infer empty for ReflectionClass::getAttributes without params
vimeo · Dec 16, 2021 · e9ad61e · e9ad61e
2 parents f4b48ab + ba6a4d8
commit e9ad61e
Show file tree

Hide file tree

Showing 2 changed files with 26 additions and 1 deletion.
diff --git a/stubs/Reflection.phpstub b/stubs/Reflection.phpstub
@@ -51,7 +51,7 @@ class ReflectionClass implements Reflector {
      * @since 8.0
      * @template TClass as object
      * @param class-string<TClass>|null $name
-     * @return array<ReflectionAttribute<TClass>>
+     * @return (TClass is object ? array<ReflectionAttribute<TClass>> : array<ReflectionAttribute<object>>)
      */
     public function getAttributes(?string $name = null, int $flags = 0): array {}
 }

diff --git a/tests/AttributeTest.php b/tests/AttributeTest.php
@@ -102,6 +102,31 @@ function foo(string $s) : void {
                 [],
                 '8.0'
             ],
+            'testReflectingAllAttributes' => [
+                '<?php
+
+                    final class a
+                    {
+                        /**
+                         * @psalm-param class-string $className
+                         */
+                        public function a(string $className): void
+                        {
+                            $a = new ReflectionClass($className);
+                            $b = $a->getAttributes();
+                            scope($b);
+                        }
+                    }
+
+                    /** @param array<ReflectionAttribute<object>> $_a */
+                    function scope($_a):void{
+
+                    }
+                    ',
+                [],
+                [],
+                '8.0'
+            ],
             'convertKeyedArray' => [
                 '<?php
                     #[Attribute(Attribute::TARGET_CLASS)]