Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Errors running using cache #1017

Closed
muglug opened this issue Oct 11, 2018 · 4 comments
Closed

Errors running using cache #1017

muglug opened this issue Oct 11, 2018 · 4 comments
Labels

Comments

@muglug
Copy link
Collaborator

muglug commented Oct 11, 2018

From @weirdan in 99eb903#comments

It's a result of a method call chain, never mentioned directly in the file.

use AnotherPackage\StorageInterface;
class C {
   /** @var StorageInterface */
   private $storage;
   public function zugzug() {
        $result = $this->storage->getRecord()->getResult(); // fails with UndefinedClass AnotherPackage\ResultInterface
   }
}

StorageInterface is defined in another composer package, so it's in (ignored) vendor folder.

namespace AnotherPackage;
interface StorageInterface {
   public function getRecord(): OperationInterface;
}
interface OperationInterface {
   public function getResult(): ResultInterface;
}
interface ResultInterface {}

Note: I get no issues with --no-cache.

@muglug muglug added the bug label Oct 11, 2018
muglug added a commit that referenced this issue Oct 12, 2018
@muglug
Copy link
Collaborator Author

muglug commented Oct 12, 2018

@weirdan I'm unable to reproduce - I tried in this test: edc219f#diff-76b547058d2f044a408e18cae81ea310R49

I've confirmed it's using the fake caches I've created.

@weirdan
Copy link
Collaborator

weirdan commented Oct 12, 2018

There might be some other factors in play here. I'll try to get a reproducer (but that probably would be no sooner than next week).

@muglug
Copy link
Collaborator Author

muglug commented Oct 17, 2018

I'm able to replicate this locally.

@muglug muglug closed this as completed in a38d2f8 Oct 17, 2018
@weirdan
Copy link
Collaborator

weirdan commented Oct 17, 2018

Yep, fixed. Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants