stream_bucket_new has wrong return type #2430
Labels
Comments
|
It did returns a resource long time ago, but I think it was changed in PHP5 judging by the list of branches that commit is a part of. |
|
Please create a PR to |
pilif
added a commit
to pilif/psalm
that referenced
this issue
Dec 6, 2019
the function returns `object` since 2003 in php/php-src@c4a491e and `stream_bucket_append()` is type hinted to take `object` too. This fixes vimeo#2430
muglug
pushed a commit
that referenced
this issue
Dec 7, 2019
the function returns `object` since 2003 in php/php-src@c4a491e and `stream_bucket_append()` is type hinted to take `object` too. This fixes #2430
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
stream_bucket_new()returnsobject|bool, but psalm thinks it's returningresource|bool.This is a problem because the return value of
stream_bucket_new()is often passed intostream_bucket_append()which psalm knows takesobjectas its second argument.This way it's impossible to write a custom stream filter that passes psalm's
InvalidArgumentcheck.I would have made a quick PR, but I'm not sure whether/if this has changed between PHP versions.
The text was updated successfully, but these errors were encountered: