UnusedMethod for private constructor

[theofidry]

If you have the following class:

final class Foo {
  private function __construct() {}

  public static function doSomething(): void { /* ... */ }
}

Then Psalm will detect UnusedMethod - 4:20 - Cannot find any calls to private method Foo::__construct (see https://psalm.dev/r/9641f1dbd6).

IMO this is a false-positive. Unlike a regular private method which if unused is dead code, a private constructor also make the class non-instantiable by "conventional" means, hence even if unused is not dead code.

[psalm-github-bot]

I found these snippets:

https://psalm.dev/r/9641f1dbd6

<?php

final class Foo {
  private function __construct() {}

  public static function doSomething(): void { /* ... */ }
}

Foo::doSomething();

Psalm output (using commit 60b3086):

INFO: UnusedMethod - 4:20 - Cannot find any calls to private method Foo::__construct

[muglug]

a private constructor also make the class non-instantiable by "conventional" means

I've separated this out into a separate issue that can be suppressed if you need

[theofidry]

👌

…

On Sun 22 Nov 2020 at 17:48, Matthew Brown ***@***.***> wrote: a private constructor also make the class non-instantiable by "conventional" means I've separated this out into a separate issue that can be suppressed if you need — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#4656 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ABHPVAIT6JYTCTG5NS6PGDLSRE6HPANCNFSM4T6MNFFA> .