3.x internal refactor

[muglug]

This changes some terminology:

• Checker -> Analyzer
• _checker -> _analyzer

Also migrates a lot of classes whose internals/APIs may change between minor versions into a Psalm\Internal namespace.

Changes the Psalm\Plugin methods so that the args have a more logical order, and so they don't depend on internal classes (this is a breaking change).

@TysonAndre: are there other plugin changes you'd like to make here? Perhaps with regards to #535? I'd be happy to add a --no-class-cache option if it's still relevant

@weirdan can any of the new plugin classes be internal?

[weirdan]

can any of the new plugin classes be internal?

All of them could be internal, apart from interfaces in PluginApi namespace.

Changes the Psalm\Plugin methods so that the args have a more logical order, and so they don't depend on internal classes (this is a breaking change).

I have additional proposal of splitting Psalm\Plugin into interfaces: https://github.com/vimeo/psalm/compare/master...weirdan:plugin-interface-segregation?expand=1
and then dropping Psalm\Plugin altogether.

[muglug]

@weirdan

I have additional proposal of splitting Psalm\Plugin into interfaces

That’s awesome - would you be able to PR that against this branch?

[coveralls]

Coverage increased (+0.05%) to 87.582% when pulling 7b3fcc2 on internal-refactor into 052d4f6 on master.

[weirdan]

Sure, will do today.

[TysonAndre]

The changes look good, I don't have any objections to the changes here, and I can't think of anything to add/remove off of the top of my head (in terms of backwards incompatible changes), other than changing plugins.

I have additional proposal of splitting Psalm\Plugin into interfaces

A similar approach was taken in Phan with Capabilities. See https://github.com/phan/phan/blob/e7583378eccea20e7c72c00be43b1b2071dcb75a/src/Phan/PluginV2.php#L17-L81

I'd be happy to add a --no-class-cache option if it's still relevant

And it's useful for plugins that want to add types from other sources

It seems like it's easy to add, independent of any breaking changes (i.e. major releases)

See https://github.com/TysonAndre/psalm/blob/94a8262f6e3ab9218ebfd7b82ccce3a56afbe568/src/psalm.php#L411-L433 - It mostly seems like you just need to replace one of the caches with a null cache to do that. I'm not familiar enough with the project to know if this would break any assumptions. Feel free to copy those changes.

[TysonAndre]

nit: Would it make more sense to move tests/Provider to tests/Internal/Provider (etc.) so that Psalm\Tests\Internal\Foo contains overrides of Psalm\Internal\Foo (e.g. if both Psalm\Provider and Psalm\Internal\Provider exist later)

[muglug]

yeah, makes sense

[weirdan]

That’s awesome - would you be able to PR that against this branch?

@muglug see #1076

[muglug]

@TysonAndre I've added a --no-reflection-cache argument that does the same job. The provider system was designed to be modular (for testing purposes) but it works well here, too.