feature: allow specifying memory limit

[mr-feek]

should close #3945

[mr-feek]

I'm not sure if this case is even possible -- however without the scalar check, psalm complained about the following:

ERROR: PossiblyInvalidCast - src/psalm.php:202:38 - list<mixed> cannot be cast to string (see https://psalm.dev/190)
    ini_set('memory_limit', (string) $memoryLimit);

[weirdan]

getopt() will return a list if you specify the option multiple times.
E.g psalm --memory-limit=1 --memory-limit=2 will result in

array(1) {
  'memory-limit' =>
  array(2) {
    [0] =>
    string(1) "1"
    [1] =>
    string(1) "2"
  }
}

[mr-feek]

today I learned!

[muglug]

Thanks!

[mshamaseen]

@muglug how to use this? I tried --memory-limit=1024M , --memory-limit=1024 but both of them failed.

[AndrolGenhald]

@mshamaseen It appears that it must be specified in bytes (--memory-limit=1073741824).

[orklah]

ini_set format should be accepted, a string is a valid scalar. So '1024M' should work.

Most probably you have a ini_set('memory_limit') in your own code that gets executed by your autoloader. Could you check if it could be the case? Try with --debug-by-line to try to see where Psalm crash

[mshamaseen]

@orklah @AndrolGenhald it does not work, it says:

vendor/bin/psalm --memory-limit=1073741824 ${CHANGED_FILES}

Target PHP version: 8.1 (inferred from composer.json) Scanning files... PHP Fatal error: Allowed memory size of 1073741824 bytes exhausted (tried to allocate 491520 bytes) in /**/vendor/barryvdh/laravel-ide-helper/resources/views/helper.php on line 34 PHP Fatal error: Allowed memory size of 1073741824 bytes exhausted (tried to allocate 65536 bytes) in /**/vendor/nunomaduro/collision/src/Highlighter.php on line 235

[AndrolGenhald]

... --memory-limit=1073741824 ... Allowed memory size of 1073741824 bytes exhausted

Looks fine to me, have you tried a higher limit?