Fix syntax check failures #8028
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
They were caused by installing packages with `--ignore-platform-reqs` which brought PHP 8.1 autoloaded packages and caused fatal errors when running php-parallel-lint. Instead of ignoring platform requirements we now remove packages that are incompatible with PHP 7.1 (phpunit and its dependents).
Merged
weirdan
added
the
release:internal
|
Shepherd issue is fixed in #8029 |
Merged
orklah
approved these changes
May 29, 2022
|
There's a build failure but I can't pinpoint what went wrong |
I think that's the one that's fixed in #8029 |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
They were caused by installing packages with
--ignore-platform-reqswhich brought PHP 8.1 autoloaded packages and caused fatal errors when
running php-parallel-lint. Instead of ignoring platform requirements we
now remove packages that are incompatible with PHP 7.1 (phpunit and its
dependents).