Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run Shepherd with 8.0 #8029

Merged
merged 1 commit into from May 30, 2022
Merged

Run Shepherd with 8.0 #8029

merged 1 commit into from May 30, 2022

Conversation

weirdan
Copy link
Collaborator

@weirdan weirdan commented May 29, 2022

Because installing packages with 8.1 and checking them as if we're
running 7.1 just doesn't work.

This was referenced May 29, 2022
@weirdan weirdan added the release:internal The PR will be included in 'Internal changes' section of the release notes label May 29, 2022
@weirdan
Copy link
Collaborator Author

weirdan commented May 29, 2022

PHP syntax is fixed in #8028

@weirdan weirdan requested a review from orklah May 29, 2022 04:47
@orklah
Copy link
Collaborator

orklah commented May 29, 2022

Do we still have a CI running on 7.1 somewhere after that? I think I remember seeing a few failures due to using incompatible syntax on 4.x

@weirdan
Copy link
Collaborator Author

weirdan commented May 29, 2022

Psalm detects the minimum PHP version supported by reading composer.json and that's 7.1 for 4.x, regardless of the actual runtime version that Composer uses during dependency resolution.

Do we still have a CI running on 7.1 somewhere after that?

I'm not sure if I understand the question. There is a job running with 7.1, the syntax check one.

Funny thing though, the latest Psalm 4.x is not installable on 7.1 because Composer requires dev dependencies to be compatible, even if they are not installed. And PHPUnit 9.0 is not compatible with 7.1

@weirdan
Copy link
Collaborator Author

weirdan commented May 29, 2022

Psalm 4.x is not installable on 7.1

Not installable with composer, that is, and it seems it never was. Phar should still run ok.

Because installing packages with 8.1 and checking them as if we're
running 7.1 just doesn't work.
@weirdan
Copy link
Collaborator Author

weirdan commented May 29, 2022

All green now, and should make the 4.x build green when merged. @orklah please merge once approved.

@orklah orklah merged commit 3aadec6 into vimeo:4.x May 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release:internal The PR will be included in 'Internal changes' section of the release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants