-
Notifications
You must be signed in to change notification settings - Fork 659
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add --no-progress to psalter #8709
Conversation
like exists in Psalm.php
Please merge |
if ($debug) { | ||
$progress = new DebugProgress(); | ||
} elseif (isset($options['no-progress'])) { | ||
$progress = new VoidProgress(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you seem to be missing an import for VoidProgress here
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, added.
In v4 circleci would have complained about that, is there maybe a bug with it in v5?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure it's classified as Code Style issue given it was an outright bug (Can php cs even know this class does not exists in this namespace??)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm 99.9% sure it previously complained for missing "use" statements in 4.x branch
Thanks! |
like exists in Psalm.php