Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove intrusive <C-K> and <C-N> mappings #128

Closed
leoroos opened this issue Jul 21, 2016 · 2 comments
Closed

remove intrusive <C-K> and <C-N> mappings #128

leoroos opened this issue Jul 21, 2016 · 2 comments
Milestone
0.5.0

Comments

@leoroos
Copy link
Contributor

leoroos commented Jul 21, 2016

In general I think it is bad behavior to force the end user to use a specific mapping, especially with vim, where a configuration can load tens of plugins to provide all the user desired functionality.

the ftplugin/votl.vim contains an array of mappings. Most of them use <localleader> and can at least be indirectly configured. But the mappings

map <silent><buffer>   <C-K>         <C-]>
map <silent><buffer>   <C-N>         <C-T>

are global and use up two easily accessible and therefore more likely already user defined mappings. Apart from having already not much worse default mappings. A typical use might be for example to use them to jump between multiple split windows as described on vim.wikia.com.

Could we please remove at least those. It is a quick and easy fix and it is easy enough to mention additional mappings in the doc that the user can then add himself to his .vimrc. In any case the user has to go through the doc to see which mappings are available.

I will add a pull request for this shortly.
leoroos pushed a commit to leoroos/vimoutliner that referenced this issue Jul 22, 2016
remove c_k c_n mappings, see vimoutliner#128
72c138d 
Don't set the mappings by default, instead
mention the possibility and how to do it in
the documentation.

Replace earlier mentions with the default
CTRL-] vim mapping.

Remove the Q mapping from the cheatsheet and the
documentation. It is not set anywhere in the code.
@mcepl mcepl mentioned this issue Jul 22, 2016
Merged
@mcepl
Copy link
Member

mcepl commented Jul 22, 2016

Fixed by #129 (commit 72c138d). Thank you!

@mcepl mcepl closed this as completed Jul 22, 2016
leoroos pushed a commit to leoroos/vimoutliner that referenced this issue Jul 22, 2016
add back internal jump mappings vimoutliner#128
bd80cee 
previous commit vimoutliner#129 unnecessarily removed these mappings

noremap <buffer> <Plug>VO_FollowLink :call <SID>follow_link()<CR>
noremap <buffer> <Plug>VO_JumpBack :call <SID>jump_back()<CR>
@leoroos
Copy link
Contributor Author

leoroos commented Jul 22, 2016

Thank you! :)
Though I was a little overzealous with my deletions and deleted by accident also the internal mappings
which don't interfere with the user mappings, see #130

@mcepl mcepl added this to the 0.5.0 milestone Feb 16, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.5.0
Development

No branches or pull requests
2 participants
@mcepl @leoroos