Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tabs module doesn't work in Firefox 51 (not e10s) #568

Closed
ghost opened this issue Aug 5, 2016 · 53 comments · Fixed by #675
Closed

Tabs module doesn't work in Firefox 51 (not e10s) #568

ghost opened this issue Aug 5, 2016 · 53 comments · Fixed by #675
Labels

Comments

@ghost
Copy link

@ghost ghost commented Aug 5, 2016

Issue type:
  • Version compatibility
Version:
Vimperator 3.15, Nightly 51.0a2, e10s disabled.
Description:

Mappings and commandline don't work.
In browser console it's showing that ReferenceError: tabs is not defined
https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Errors/Not_defined

@timss timss added the compatibility label Aug 6, 2016
@ghost ghost changed the title Vimperator don't work in Nightly. Sandbox support in Nightly. Aug 7, 2016
@ghost ghost changed the title Sandbox support in Nightly. Vimperator don't work in Nightly. Aug 7, 2016
@ghost ghost changed the title Vimperator don't work in Nightly. Vimperator don't work in .Firefox Developer Edition. Sep 20, 2016
@ghost ghost changed the title Vimperator don't work in .Firefox Developer Edition. Vimperator don't work in Firefox Developer Edition. Sep 20, 2016
@ghost ghost mentioned this issue Oct 5, 2016
@tinkerttoy

This comment has been minimized.

Copy link

@tinkerttoy tinkerttoy commented Oct 31, 2016

I think I found the problem. See #211. Developer Edition has e10s enabled by default, so that'd explain why it's broken. Looks like e10s support ought to get moved up the priority list.

@gkatsev

This comment has been minimized.

Copy link
Member

@gkatsev gkatsev commented Oct 31, 2016

Going to close as a duplicate of #211 then. e10s is at the top but there's not a lot of people who know a lot about e10s and also have time to work on it unfortunately :(

@gkatsev gkatsev closed this Oct 31, 2016
@timss timss added the duplicate label Oct 31, 2016
@ghost

This comment has been minimized.

Copy link
Author

@ghost ghost commented Nov 1, 2016

@tinkerttoy @gkatsev it's not e10s issue, it's not working with e10s disabled, i pointed that out in issue.

@ghost ghost changed the title Vimperator don't work in Firefox Developer Edition. Vimperator don't work in Firefox Developer Edition. Not e10s. Nov 1, 2016
@gkatsev

This comment has been minimized.

Copy link
Member

@gkatsev gkatsev commented Nov 1, 2016

Oh, I see. Sorry, re-opening.

@gkatsev gkatsev reopened this Nov 1, 2016
@timss timss removed the duplicate label Nov 1, 2016
@deathbeam

This comment has been minimized.

Copy link

@deathbeam deathbeam commented Nov 1, 2016

Same problem here, most of stuff is working, except everything related to tabs and preference pane.

@RomanHargrave

This comment has been minimized.

Copy link

@RomanHargrave RomanHargrave commented Nov 8, 2016

Same, as above.

List of things that are working here, at least that I have noticed:

  • Open in focused tab (:open)
  • winclose, winopen, winonly, and window

Everything else probably is too.

List of things not working

  • All commands named like tab* are not even present

Version: vimperator-3.15.0-11-gb9c1f0d

@teranex

This comment has been minimized.

Copy link

@teranex teranex commented Nov 16, 2016

I updated to Firefox 51 beta yesterday and Vimperator (particularly :tabopen) is broken.

:version
Vimperator: 3.15.0 (created: 2016/10/05 01:11:26)
Firefox: Mozilla/5.0 (X11; Ubuntu; Linux x86_64; rv:51.0) Gecko/20100101 Firefox/51.0

@xTpx

This comment has been minimized.

Copy link

@xTpx xTpx commented Nov 16, 2016

Same problem on Fx 51 Beta ("Mozilla/5.0 (X11; Linux x86_64; rv:51.0) Gecko/20100101 Firefox/51.0").
f/r & c-n/p, shift-h/l not work, e10s is disable.
The console show
liberator: Error loading script tabs.js: SyntaxError: non-generator method definitions may not contain yield load @chrome://liberator/content/liberator-overlay.js:17:17 @chrome://liberator/content/liberator-overlay.js:66:5 @chrome://liberator/content/liberator-overlay.js:6:2

@timss

This comment has been minimized.

Copy link
Member

@timss timss commented Nov 16, 2016

Protip: use the ESR instead of betas or bleeding edge releases, for better compatability..

@SammysHP

This comment has been minimized.

Copy link
Member

@SammysHP SammysHP commented Nov 24, 2016

@timss Which does not work when using own builds of Vimperator (e.g. development / custom modifications) if you don't want to send every build to Mozilla for signing (which works automatically with my makefile modification, but takes a 10-60 seconds longer).

@ghost ghost changed the title Vimperator don't work in Firefox Developer Edition. Not e10s. Vimperator don't work in Firefox Beta. Not e10s. Dec 18, 2016
@nornagest

This comment has been minimized.

Copy link

@nornagest nornagest commented Jan 22, 2017

I have just noticed this problem too, after upgrading Firefox.
Release date for Firefox 51 is 2017-01-24 - only two days away.

Vimperator: 3.15.0 (created: 2016/10/05 01:11:26)
Firefox: Mozilla/5.0 (X11; FreeBSD amd64; rv:51.0) Gecko/20100101 Firefox/51.0

@Nefari0uss

This comment has been minimized.

Copy link

@Nefari0uss Nefari0uss commented Jan 22, 2017

@timss I don't think telling people to switch to ESR is the best way of going about the E10s issue. All it does is kick it down the road.

@timss

This comment has been minimized.

Copy link
Member

@timss timss commented Jan 24, 2017

@Nefari0uss It most certainly is not, but it's one currently viable, working option. Although at this point not for long, as the next ESR release Firefox 52 is set to release March 2017:

As far as e10s or WebExtensions development goes, the status unfortunately hasn't changed too much since I wrote this back in September. I don't personally have the time to change much about that. Some PRs come in from time to time (thanks!), and a couple recently got merged by @maxauthority. But the e10s/WE issue still stands.

@sandermarechal

This comment has been minimized.

Copy link

@sandermarechal sandermarechal commented Jan 25, 2017

Firefox 51 was released today, breaking Vimperator as described. Any update on a fix?

@SammysHP

This comment has been minimized.

Copy link
Member

@SammysHP SammysHP commented Jan 25, 2017

Firefox 51 is not in the Arch repository yet, so I cannot test. This might fix it, but there are also a lot of other generator functions without function*. I tried to fix all but then vimperator didn't work at all.

diff --git a/common/content/tabs.js b/common/content/tabs.js
index 8410e325..89948885 100644
--- a/common/content/tabs.js
+++ b/common/content/tabs.js
@@ -52,7 +52,7 @@ const Tabs = Module("tabs", {
      * @property {Iterator(Object)} A genenerator that returns all browsers
      *     in the current window.
      */
-    get browsers() {
+    browsers: function* () {
         let browsers = config.tabbrowser.browsers;
         for (let i = 0; i < browsers.length; i++)
             yield [i, browsers[i]];

See also: https://developer.mozilla.org/docs/Web/JavaScript/New_in_JavaScript/Firefox_JavaScript_changelog#Firefox_51

@ma8ma

This comment has been minimized.

Copy link
Contributor

@ma8ma ma8ma commented Jan 25, 2017

@SammysHP Looks good to me. The patch makes to work the tab operations on Firefox Developer Edition 52.0a2 😄

@dcrozz

This comment has been minimized.

Copy link

@dcrozz dcrozz commented Jan 30, 2017

It seems that though I replace the xpi for FirefoxDeveloperEdition by following the steps listed by @DarkPrinceFrost , the vimperator works for a minute but so many error messages pop-up such as TypeError: 'stopPropagation' called on an object that does not implement interface Event. or TypeError: m.getClientRects is not a function. from time to time, and the hotkey I set such as map H <C-p> doesn't work accidentally.
The system I use is osx 10.11.6, Firefox 51.0.1 (64-bit).
Maybe I should give up and wait for the next vimperator version?

ma8ma added a commit to ma8ma/vimperator-labs that referenced this issue Jan 30, 2017
* Replace legacy generator with ES2015 generator for almost places.
* Replace non-standard Array comprehension with Array methods
  in muttator/content/mail.js.

Several legacy generators still keep because they have been handled
by legacy iterators:
* iter() in common/content/base.js
* callbacks of addPageInfoSection() in common/content/buffer.js
* evaluateXPath() in common/content/util.js
* range() in common/content/util.js
* itervalues() in common/content/util.js
* iteritems() in common/content/util.js
@mwelt

This comment has been minimized.

Copy link

@mwelt mwelt commented Jan 30, 2017

@chocolateboy Somehow your instructions yield
screen shot 2017-01-30 at 22 02 15

Any suggestions, what I might do wrong here?

@timss timss closed this in #675 Jan 31, 2017
timss added a commit that referenced this issue Jan 31, 2017
* Replace legacy generator with ES2015 generator for almost places.
* Replace non-standard Array comprehension with Array methods
  in muttator/content/mail.js.

Several legacy generators still keep because they have been handled
by legacy iterators:
* iter() in common/content/base.js
* callbacks of addPageInfoSection() in common/content/buffer.js
* evaluateXPath() in common/content/util.js
* range() in common/content/util.js
* itervalues() in common/content/util.js
* iteritems() in common/content/util.js
@timss timss changed the title Vimperator don't work in Firefox Beta. Not e10s. Tabs module doesn't work in Firefox 51 (not e10s) Jan 31, 2017
@timss

This comment has been minimized.

Copy link
Member

@timss timss commented Jan 31, 2017

@chelmuth

This comment has been minimized.

Copy link

@chelmuth chelmuth commented Jan 31, 2017

Great to see this issue fixed. Is there already a plan when it will be available from https://addons.mozilla.org/en-US/firefox/addon/vimperator/?

@boreq

This comment has been minimized.

Copy link

@boreq boreq commented Feb 2, 2017

I think it is a bit weird that you decided to sit on the information that Vimperator is broken in the new stable release of Firefox and did nothing. As far as I can see that information was available for months and yet nothing was done about it untill today (okay, a commit was made but that doesn't mean much without the new Vimperator release). I find this a bit unprofessional for an addon with 30000 users. And as it is the major bug is still present after several days, which frankly I find quite annoying. I think some kind of a change to your relase process would be a good idea.

@SammysHP

This comment has been minimized.

Copy link
Member

@SammysHP SammysHP commented Feb 2, 2017

"30000 users vs 0 developers" should explain it. But thanks that you want help us in the future. I look forward to see some nice commits fixing some of the issues. :)

@chelmuth

This comment has been minimized.

Copy link

@chelmuth chelmuth commented Feb 2, 2017

Isn't vimperator an admittedly successful, widely-adopted open-source project backed by diligent volunteers? I don't think it's fair to apply professional (whatever that means) standards in this case. It would be fair if anybody who's annoyed by a shortcoming would get started fixing the bug and contribute to the project. I myself did not pay anything for an addon that makes Firefox usable for years now and so I'm pretty glad it is still maintained while others just vanished. Thanks devs for your hard work!

@rwestlund

This comment has been minimized.

Copy link

@rwestlund rwestlund commented Feb 2, 2017

+1. You don't get to complain about things you get for free. I think it's pretty awesome that vimperator works 99.99% of the time, and all I had to do was click install :)

@timss

This comment has been minimized.

Copy link
Member

@timss timss commented Feb 2, 2017

Much like @chelmuth said, "unprofessional" is exactly what Vimperator and most other Firefox addons are. The work done by previous and current contributors is done in our spare time, for free. It should go without saying, but such entitlement is not only misplaced, but also an annoyance in the open source community that contributors and maintainers should be spared.

This was referenced Feb 2, 2017
@ghost

This comment has been minimized.

Copy link
Author

@ghost ghost commented Feb 2, 2017

I'm in the situation that I simply don't have the time to contribute to vimperator myself, I'd imagine others are in the same situation. I'm willing to do what I can: give money to help with development (in a way that vimperator stays open source, rather than become paid software). The epub-reader addon is in a similiar situation as vimperator: it needs a rewrite w.r.t. to the changes planned by Mozilla. The dev behind it started a kickstarter project[1] so he can work full time on doing said rewrite. Might this be an option for vimperator? Kickstart money to either hire a dev or enable an existing dev to spend time on a rewrite?

[1] https://www.kickstarter.com/projects/569473473/epubreader-for-future-firefox

@vlcinsky

This comment has been minimized.

Copy link

@vlcinsky vlcinsky commented Feb 2, 2017

This shows, some things are not only technical, but also require some managerial effort.

Some people like coding, others are able to manage all the stuff around funding. I can understand, some great coders hate any organizational stuff.

It would be great to have vimperator functional in future - with Mozilla planned switch. Demand is very strong (vimperator is in muscles of many very productive people) and I am sure the chance for enough funds is very high.

My proposal is:

  • is main developer willing to organize the funding?
  • if not, is there anybody, who would be willing to help him with that? If so, can they agree on setting up the campaign together?

PS: Personally, I have no experience with such project, so I cannot serve myself. Just wanted to propose possible path of development (and yes, count with my 50 USD contribution if it ever starts - it was already worth 2x10 USD in past).

@wmorrell

This comment has been minimized.

Copy link

@wmorrell wmorrell commented Feb 2, 2017

What main developer? There currently are none. It's a project that was open-sourced a long time ago, and a few enthusiasts here and there continue to volunteer time to maintain it. It's nobody's day-job. If you feel like donating, there are PayPal and Flattr buttons on the vimperator.org website. Please do not encourage setting up alternate funding, that will only draw donations away and potentially direct the funding to scammers or less scrupulous individuals.

The current maintainers have repeatedly said, funding is not the issue. Work submitting patches, or re-implementing as WebExtensions instead of XUL, is needed. Experience is not required; you get the experience by doing things you have not done before. If you have the time, great! Lots of people will appreciate your effort. But please, if you do not have the time, refrain from complaining about the efforts of the existing volunteers.

@vlcinsky

This comment has been minimized.

Copy link

@vlcinsky vlcinsky commented Feb 2, 2017

@wmorrell Did I complain about the efforts of the existing volunteers? I did not intend to as I appreciate the effort really a lot.

"Money are not the problem", many users using vimperator, growing technical debt due to lack of programmers: this is not fault of existing volunteers at all. To me it is a sign of lack of structure in processes and organization as energy (money, demand) exist but do not flow well enough where required. Trying to think forward I feel, there is a need for a lead (or two), who could help the great solution to evolve.

I did not want to offend anyone. I just tried to contribute to a solution, I love so much (btw: is there some better place to discuss such things?).

My fingers are tapping the thanksgiving song many times a day: Vimperator is my daily tool with that my browsing can fly at speed of thought, thanks all the contributors and I wish all of us: Live long and prosper, dear Vimperator.

@wmorrell

This comment has been minimized.

Copy link

@wmorrell wmorrell commented Feb 2, 2017

@vlcinsky The more egregious complaining is further up-thread. Your comments are not of the same degree or severity, and I appreciate and believe that you are not intending to complain. It is just not helpful to comment along the lines of, "why is there no-one doing X?" especially if it's immediately followed by, "I won't do it." That reads as entitlement to the time and effort of the existing volunteers working on what you want.

I intend to make a weekend afternoon project to learn more about WebExtensions APIs. It won't get Vimperator ready for the final deprecation of XUL in Firefox 57, but it is a step in the right direction.

@blueyed

This comment has been minimized.

Copy link

@blueyed blueyed commented Feb 2, 2017

I think we should lock this issue, and rather create a new one for discussions.

From my point of view a lot of people (and especially developers) are using OSS, but do not contribute back: if you find an issue, please consider digging into the source! That's not easy for all projects (e.g. Vimperator), but you should be able to create a local build, find the place to hack and then investigate. And if you stumble while doing so, please at least create a PR for better docs while you find out something.

(I am maintaining some Vim plugins, and it is really discouraging if e.g. Python developers using jedi-vim are creating duplicate issues, instead of figuring out what is wrong, and then submit a small PR to fix it (although the problem is in the Python code))

Therefore it's not really money that's the issue, but rather to make development/hacking easy (docs!), and that users (especially developers) are willing to contribute back.

@timss

This comment has been minimized.

Copy link
Member

@timss timss commented Feb 2, 2017

Good idea, @blueyed. We don't want to end up in nikolas/github-drama! :p

There are some valid points that are brought up here, but should be done in a constructive manner in a seperate issue. I have some ideas how that could be done, so sit tight until I've made such an issue. In addition, lets all recognize that we want the same thing, and try to avoid fruitless discussion(s).

@vimperator vimperator locked and limited conversation to collaborators Feb 2, 2017
@gkatsev

This comment has been minimized.

Copy link
Member

@gkatsev gkatsev commented Feb 17, 2017

Vimperator 3.16.0 has been officially approved. They did note two things that need to be looked at for an upcoming release. I'll open a new issue for those.

@gkatsev

This comment has been minimized.

Copy link
Member

@gkatsev gkatsev commented Feb 17, 2017

Also, thanks to everyone who made this release possible!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
You can’t perform that action at this time.