Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make all appropriate settings wikilocal #894

Closed
15 tasks done
Nudin opened this issue May 30, 2020 · 3 comments
Closed
15 tasks done

Make all appropriate settings wikilocal #894

Nudin opened this issue May 30, 2020 · 3 comments
Assignees
@tinmarino
Labels
config Related to configuration: default, customization enhancement hacktoberfest https://hacktoberfest.digitalocean.com/details idea inconsistency ref Long term run, to use as a reference
Projects
v2.6

Comments

@Nudin
Copy link
Member

Nudin commented May 30, 2020 •
edited by tinmarino

For historic reason some settings are global even though there is no reason to have them not as wikilocal settings. Therefore, it isn't possible to have multiple wikis with different values for these settings.

These are settings that affect the wikitext and should therefore be changeable on a per-wiki scope:

  • vimwiki_listsyms
  • vimwiki_listsym_rejected
  • vimwiki_list_ignore_newline (5700313)
  • vimwiki_text_ignore_newline
  • vimwiki_markdown_link_ext (4672deb)
  • vimwiki_toc_header, vimwiki_toc_header_level, vimwiki_toc_link_format (c4570886b04)

These are options that only change the displaying, they could be wikilocal but for most users it's also fine if they are global only:

  • vimwiki_hl_headers
  • vimwiki_hl_cb_checked
  • vimwiki_folding
  • vimwiki_create_link

The following options only make sense as global options and should stay such:

  • vimwiki_use_calendar
  • vimwiki_menu
  • vimwiki_ext2syntax
  • vimwiki_global_ext

Related Issues:
@Nudin
Copy link
Member Author

Nudin commented May 30, 2020

PR #889 makes the first two (vimwiki_listsyms & vimwiki_listsym_rejected) wiki-local. To do so it adds "tooling" to have settings that are usable as global and wiki-local. Through this vimwiki stays backward compatible: global settings continue to work but local options are used if pressent.

@Nudin Nudin mentioned this issue May 30, 2020
Merged
@Nudin Nudin mentioned this issue May 31, 2020
Open
@Nudin Nudin changed the title Make all usefull settings wikilocal Make all appropriate settings wikilocal May 31, 2020
@Nudin Nudin added this to To do in v2.6 Jun 8, 2020
This was referenced Jul 25, 2020
Closed
Closed
Open
@tinmarino tinmarino added config Related to configuration: default, customization ref Long term run, to use as a reference labels Jul 27, 2020
@tinmarino tinmarino mentioned this issue Jul 30, 2020
Closed
tinmarino added a commit to tinmarino/vimwiki that referenced this issue Jul 30, 2020
@tinmarino
Refactor: Vars: Make vimwiki_list_ignore_newline wiki local (Issue vi…
5700313 
…mwiki#894)

Also: vimwiki_text_ignore_newline
tinmarino added a commit to tinmarino/vimwiki that referenced this issue Jul 30, 2020
@tinmarino
Refactor: Vars: Make vimwiki_list_ignore_newline wiki local (Issue vi…
5d170fb 
…mwiki#894)

Also: vimwiki_text_ignore_newline
tinmarino added a commit to tinmarino/vimwiki that referenced this issue Jul 30, 2020
@tinmarino
Refactor: Vars: Make vimwiki_list_ignore_newline wiki local (Issue vi…
97e0289 
…mwiki#894)

Also: vimwiki_text_ignore_newline
@tinmarino tinmarino mentioned this issue Aug 18, 2020
Merged
@tinmarino tinmarino added the hacktoberfest https://hacktoberfest.digitalocean.com/details label Oct 20, 2020
@tinmarino
Copy link
Member

Hacktoberfest point for any issue referenced or referencing this one and some are pretty easy: just dictionary refactoring.

deepredsky pushed a commit to deepredsky/vimwiki that referenced this issue Jan 16, 2021
@tinmarino @deepredsky
Refactor: Vars: Make vimwiki_list_ignore_newline wiki local (Issue vi…
dd8cbbf 
…mwiki#894)

Also: vimwiki_text_ignore_newline
@tinmarino tinmarino mentioned this issue Jun 11, 2021
Closed
jls83 pushed a commit to jls83/vimwiki that referenced this issue Jan 17, 2023
@tinmarino @jls83
Refactor: Vars: Make vimwiki_list_ignore_newline wiki local (Issue vi…
09721cd 
…mwiki#894)

Also: vimwiki_text_ignore_newline
@tinmarino tinmarino self-assigned this Jun 26, 2023
@qadzek qadzek mentioned this issue Jul 8, 2023
Open
@tinmarino
Copy link
Member

I think most of the refactoring have been done by now. If someone have specific variables to move, please link the new issue to this one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tinmarino tinmarino

Labels
config Related to configuration: default, customization enhancement hacktoberfest https://hacktoberfest.digitalocean.com/details idea inconsistency ref Long term run, to use as a reference
Projects
Feature Triage
Status: Done
v2.6
  
To do
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Nudin @tinmarino