Bugfix: file extension for markdown is syntax wide #895
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The alternative solution would have been moving |
Yes good idea, but currently a premature optimization. This PR is working towards separating wiki and syntax which is the good way. Once they are separated, it will be really easy to:
This way, we can move the syntax feature requests to the user scope. |
deepredsky
pushed a commit
to deepredsky/vimwiki
that referenced
this pull request
Jan 16, 2021
populate_extra_markdown_vars() contained uses of the file-extension via vimwiki#vars#get_wikilocal. Since the first is syntax-wide and the second is wikilocal and no wiki is specified or open at the moment of the call, the file extension of the first markdown wiki will be used for all markdown wikis. Further problems will occur when adding new wikilocal options, that depend on the syntax. This commit is working towards separating wiki and syntax, which is needed for several feature requests.
jls83
pushed a commit
to jls83/vimwiki
that referenced
this pull request
Jan 17, 2023
populate_extra_markdown_vars() contained uses of the file-extension via vimwiki#vars#get_wikilocal. Since the first is syntax-wide and the second is wikilocal and no wiki is specified or open at the moment of the call, the file extension of the first markdown wiki will be used for all markdown wikis. Further problems will occur when adding new wikilocal options, that depend on the syntax. This commit is working towards separating wiki and syntax, which is needed for several feature requests.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
populate_extra_markdown_vars()contained uses of the file-extension viavimwiki#vars#get_wikilocal. Since the first is syntax-wide and the second iswikilocal and no wiki is specified or open at the moment of the call, the file
extension of the first markdown wiki will be used for all markdown wikis.
This PR fixes this via use of the existing template infrastructure.
This bug becomes critical when merging #889 or fixing #894.