-
Notifications
You must be signed in to change notification settings - Fork 620
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added handling of absolute path to vimwiki #811
Conversation
…esolved - add [[//absolute_path]] to handle absolute path - updated doc to reflect the changes
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Change test path to be docker coherent
Log 'Hello !' | ||
|
||
Given vimwiki(some wiki link): | ||
[[//$UVMKIT_HOME/uvm/src/seq/uvm_sequencer_base.svh|uvm_sequencer_base::wait_for_sequences]] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This absolute path specific to your machine ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes. Sorry!! nice catch ... will remove it
Neat ! With doc and test. All in one commit. Seems clean. |
It is not working on my machine. [test1](//home2/tourneboeuf/Test/Wiki/test.md) I improved a little bit your Vader test. But itdoes not work as the absolute link is not creating so the filetype is not the one expected.
|
…ustrajdeep - update vimwiki link handling so that if using env variables it is resolved - add [[//absolute_path]] to handle absolute path - updated doc to reflect the changes
Hi, Rebased manually: e3e841f Tests are important: For example, the raw inclusion of your modifications broke some : https://travis-ci.com/github/vimwiki/vimwiki/builds/176612972 Anyway good job, it is working. |
…ustrajdeep - update vimwiki link handling so that if using env variables it is resolved - add [[//absolute_path]] to handle absolute path - updated doc to reflect the changes
…ustrajdeep - update vimwiki link handling so that if using env variables it is resolved - add [[//absolute_path]] to handle absolute path - updated doc to reflect the changes
Steps for submitting a pull request:
dev
branch!doc/vimwiki.txt
if applicable,including the Changelog and Contributors sections.