Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add phpstan and check composer script #19

Merged
merged 4 commits into from
Jan 8, 2021

Conversation

n-peugnet
Copy link
Contributor

@n-peugnet n-peugnet commented Jan 8, 2021

  • add phpstan to dev requirements
  • add some more symfony checks
  • fix .vscode folder

Infos

PHPStan is in my opinion the most important check tool for PHP. It is configured with a level of 5.
I Also added recommended extensions in this pull request, and by the way I removed .vscode folder from the git as it is environment dependent.

Once this is merged, vscode will suggest to install exension. It is best to install them and uninstall the ones you had previously that do the same thing to avoid collisions (using the filter @installed php and most importantly for "phpstan" and "rename symbols").
Also, as I removed launch.json form .vscode you will have to recreate it with this content:

{
    // Use IntelliSense to learn about possible attributes.
    // Hover to view descriptions of existing attributes.
    // For more information, visit: https://go.microsoft.com/fwlink/?linkid=830387
    "version": "0.2.0",
    "configurations": [
        {
            "name": "Listen for XDebug",
            "type": "php",
            "request": "launch",
            "port": 9005
        }
    ]
}

Part of #17

- remove launch.json as it is environment dependent
- add extensions.json to recommend useful extensions
@vincent-peugnet vincent-peugnet merged commit 7910d58 into vincent-peugnet:main Jan 8, 2021
@n-peugnet n-peugnet deleted the check-tools branch January 8, 2021 16:00
@n-peugnet n-peugnet mentioned this pull request Jan 15, 2021
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants