Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix most of phpstan errors #21

Merged
merged 1 commit into from
Jan 8, 2021
Merged

Fix most of phpstan errors #21

merged 1 commit into from
Jan 8, 2021

Conversation

n-peugnet
Copy link
Contributor

@n-peugnet n-peugnet commented Jan 8, 2021 •
edited by vincent-peugnet
Loading

It is better for you to understand how I fixed phpstan errors on a separate pull-request.

Checklist

  1. merge Add phpstan and check composer script #19
  2. install dependencies: composer install
  3. run checks: composer check
  4. for each error see in this pr how I solved it

Info

There are 2 errors left but those require choices from you @vincent-peugnet.

@n-peugnet n-peugnet marked this pull request as ready for review January 8, 2021 10:52
@vincent-peugnet vincent-peugnet merged commit 22b1d66 into vincent-peugnet:main Jan 8, 2021
@n-peugnet n-peugnet deleted the fix-phpstan branch January 8, 2021 17:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@n-peugnet @vincent-peugnet