Fix invalid memory access issue in g++ builds #228
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also added test for empty file SEGFAULT
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix invalid memory access issues in g++ builds caused when accessing
CSVFieldmethods while using theCSVRowreverse iterator.This was caused by a workaround to previous versions of g++ not supporting the use of
std::shared_ptras a pointer type in iterators, thus requiring the fallback use of raw pointers (which would cause thestd::shared_ptr<CSVField>to go out of scope and get deleted.Now that newer versions of g++ don't have this problem, we can remove the dubious workaround.