Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

importing schedula imports every module there is #11

Closed
ankostis opened this issue May 20, 2018 · 1 comment
Closed

importing schedula imports every module there is #11

ankostis opened this issue May 20, 2018 · 1 comment

Comments

@ankostis
Copy link
Contributor

The way it is structure this project, when importing schedula.__init__.py, it imports recursively all modules beneath them. In modern computers this is fast, but in general it should be possible to selectively import what is needed.
vinci1it2000 added a commit that referenced this issue Oct 26, 2018
@vinci1it2000
fix(chore), #11: Lazy import of dill module.
da9c432
vinci1it2000 added a commit that referenced this issue Oct 27, 2018
@vinci1it2000
fix(chore), #11: Lazy import of dill module.
90c784d
vinci1it2000 added a commit that referenced this issue Nov 1, 2018
@vinci1it2000
fix(chore), #11: Use __getattr__ to import module attributes.
e2beb74
vinci1it2000 added a commit that referenced this issue Nov 4, 2018
@vinci1it2000
fix(chore), #11: Use __getattr__ to import module attributes.
8d31e23
vinci1it2000 added a commit that referenced this issue Nov 4, 2018
@vinci1it2000
fix(chore), #11: Use __getattr__ to import module attributes.
694cef6
vinci1it2000 added a commit that referenced this issue Nov 4, 2018
@vinci1it2000
fix(chore), #11: Use __getattr__ to import module attributes.
91b4942
vinci1it2000 added a commit that referenced this issue Nov 5, 2018
@vinci1it2000
fix(chore), #11: Lazy import of concurrent.futures, tempfile, and…
ef372dd 
… `inspect`.
@vinci1it2000
Copy link
Owner

For python 3.7 schedula uses __getattr__ to import module attributes.
While for older python versions it imports all attributes but it takes max 12 ms.

vinci1it2000 added a commit that referenced this issue Nov 5, 2018
@vinci1it2000
fix(chore), #11: Use importlib to import relative sub modules.
23b6fde
vinci1it2000 added a commit that referenced this issue Nov 5, 2018
@vinci1it2000
fix(chore), #11: Use exec to import relative sub modules in python …
e4dd155 
…< 3.7 for autocompletion.
vinci1it2000 added a commit that referenced this issue Nov 5, 2018
@vinci1it2000
fix(chore), #11: Use __getattr__ to import relative sub modules in …
dd8c9b1 
…python < 3.7.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ankostis @vinci1it2000