Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improves vue-page-title reactivity when using vue-router #21

Merged
merged 7 commits into from
Aug 25, 2022

Conversation

ricardocastanho
Copy link
Contributor

@ricardocastanho ricardocastanho commented Aug 23, 2022

Improves vue-page-title reactivity when using vue-router

Now the route are watched and when it changes the title function are re-called.

  • Improves vue-page-title reactivity when using vue-router.
  • Add vue-router usage tests.
  • Update docs.
<script>
export default {
  title () {
    return `My title is: ${this.$route.query.foo}`
  }
}
</script>

@ricardocastanho ricardocastanho changed the title Feature/watch router Improves vue-page-title reactivity when using vue-router Aug 23, 2022
watches the title changes when it's a function
test title watching
@vinicius73 vinicius73 merged commit 5b92d83 into vinicius73:master Aug 25, 2022
@ricardocastanho ricardocastanho deleted the feature/watch_router branch August 25, 2022 16:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants