Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace dicttoxml as it is no longer maintained. Last commit is from 2016. #69

Closed
oponcea-dn opened this issue Apr 15, 2021 · 6 comments
Assignees

Comments

@oponcea-dn
Copy link

oponcea-dn commented Apr 15, 2021

Is your feature request related to a problem? Please describe.
Replace dicttoxml as it is no longer maintained. Last commit is from 2016.

Describe the solution you'd like
Any library that supports attributes as quandyfactory/dicttoxml#66 is not merged.

Describe alternatives you've considered
https://github.com/mbj4668/pyang/blob/master/bin/json2xml

@vinitkumar vinitkumar self-assigned this Apr 19, 2021
@vinitkumar
Copy link
Owner

@oponcea-dn Thanks for filing a ticket. Let me see what I can do about it.

@vinitkumar
Copy link
Owner

Hi @oponcea-dn. Are you sure you wanted to open a ticket in this repo? I am sure the development has slowed down in the dicttoxml repo, but it just works for me and removing it means writing that code myself or finding a suitable alternative (please suggest if you know any).

@oponcea-dn
Copy link
Author

Hi @vinitkumar, thanks for answering and I apologize for not updating this issue earlier. So, looking more over the code of Ansible, it is actually NOT using this library but it is calling the "json2xml" command of pyang so you can reject my suggestion.

As an alternative, if you have time, maybe you can adapt the code from pyang to the interface of this library: https://github.com/mbj4668/pyang/blob/master/bin/json2xml ... it has a different licencing (BSD 3 clause) but should be ok if you grab the file and the licence.

@vinitkumar
Copy link
Owner

vinitkumar commented May 10, 2021 via email

@vinitkumar
Copy link
Owner

vinitkumar commented Aug 22, 2021

@oponcea-dn You were right, the code for dict2xml is old, unmaintained and messy. I have forked it, and it is in development now. You are welcome to test this branch out.

#75

@vinitkumar
Copy link
Owner

vinitkumar commented Aug 28, 2021

The forked version of the dicttoxml is mergd with the latest beta release.

https://github.com/vinitkumar/json2xml/releases/tag/v3.7.0beta1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants