Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

item ommision #76

Merged
merged 3 commits into from Sep 10, 2021
Merged

item ommision #76

merged 3 commits into from Sep 10, 2021

Conversation

jgroom33
Copy link
Contributor

@jgroom33 jgroom33 commented Sep 9, 2021

Wrapping array items in <item>...</item> should be optional

This PR supports:

{"my_items":[{"my_item":{"id":1} },{"my_item":{"id":2} }]}

conversion to:

    <all>
      <my_items type="list">
        <my_item>
            <id type="int">1</id>
        </my_item>
        <my_item>
            <id type="int">2</id>
        </my_item>
      </list>
    </all>

@jgroom33
Copy link
Contributor Author

jgroom33 commented Sep 9, 2021

resolve #77

json2xml/json2xml.py Outdated Show resolved Hide resolved
@vinitkumar
Copy link
Owner

Great work implementing this neat feature @jgroom33. ✅

Could you please add tests for it as well? That would be great and also do one change as I commented on your PR. I will have no issues merging and doing a new release with it then.

handle attr_type=True with item_wrap=False
@vinitkumar
Copy link
Owner

This is some brilliant work @jgroom33. Thanks for contributing this patch. I will be merging this one now.

@vinitkumar vinitkumar merged commit ff1351a into vinitkumar:master Sep 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants