Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Landing Page Design in AdobeXD (Instance #7) #227

Merged
merged 2 commits into from
Apr 2, 2020
Merged

Landing Page Design in AdobeXD (Instance #7) #227

merged 2 commits into from
Apr 2, 2020

Conversation

SaranshDawra
Copy link

Description

I have made a landing page design for Water Monitoring System using Adobe XD.

Fixes #173

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • This change requires a documentation update

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • Any dependent changes have been merged and published in downstream modules

Reviewer: Vinit Shahdeo

@auto-assign auto-assign bot requested a review from vinitshahdeo April 1, 2020 21:04
@SaranshDawra SaranshDawra changed the title Landing Page Design in AdobeXD Landing Page Design in AdobeXD (Instance #7) Apr 1, 2020
vinitshahdeo
vinitshahdeo reviewed Apr 2, 2020
View reviewed changes
Copy link
Owner

@vinitshahdeo vinitshahdeo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@SaranshDawra Can you please share a screenshot(.jpg or .png) as well?

@SaranshDawra
Copy link
Author

@vinitshahdeo I have added the png file please check.

@vinitshahdeo vinitshahdeo added gssoc20 Welcome to GirlScript Summer of Code 2020 medium medium level issue labels Apr 2, 2020
@vinitshahdeo vinitshahdeo merged commit 4e1743f into vinitshahdeo:feature/frontend Apr 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vinitshahdeo vinitshahdeo vinitshahdeo approved these changes

Assignees

@vinitshahdeo vinitshahdeo

Labels
gssoc20 Welcome to GirlScript Summer of Code 2020 medium medium level issue
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@SaranshDawra @vinitshahdeo