Add parse_dec tests

vinniefalco · Jul 30, 2018 · 6d1bd38 · 6d1bd38
1 parent 8023908
commit 6d1bd38
Show file tree

Hide file tree

Showing 2 changed files with 38 additions and 0 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -1,6 +1,7 @@
 Version 181:
 
 * Fix parse_dec algorithm
+* Add parse_dec tests
 
 --------------------------------------------------------------------------------
 

diff --git a/test/beast/http/basic_parser.cpp b/test/beast/http/basic_parser.cpp
@@ -1213,6 +1213,42 @@ class basic_parser_test : public beast::unit_test::suite
         BEAST_EXPECT(ec);
     }
 
+    void
+    testIssue1211()
+    {
+        using base = detail::basic_parser_base;
+        auto const good =
+            [&](string_view s, unsigned long v0)
+            {
+                unsigned long v;
+                auto const result =
+                    base::parse_dec(s.begin(), s.end(), v);
+                if(BEAST_EXPECTS(result, s))
+                    BEAST_EXPECTS(v == v0, s);
+            };
+        auto const bad =
+            [&](string_view s)
+            {
+                unsigned long v;
+                auto const result =
+                    base::parse_dec(s.begin(), s.end(), v);
+                BEAST_EXPECTS(! result, s);
+            };
+        good("0",           0);
+        good("00",          0);
+        good("001",         1);
+        good("255",         255);
+        good("65535",       65535);
+        good("65536",       65536);
+        good("4294967295",  4294967295);
+        bad ("");
+        bad (" ");
+        bad (" 0");
+        bad ("0 ");
+        bad ("-1");
+        bad ("4294967296");
+    }
+
     //--------------------------------------------------------------------------
 
     void
@@ -1237,6 +1273,7 @@ class basic_parser_test : public beast::unit_test::suite
         testIssue692();
         testFuzz();
         testRegression1();
+        testIssue1211();
     }
 };