Demonstration of Extension Approach 2 #47
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Provide Schema and Support function DSL through ModelExtension Provide Router Addition DSL through RouterExtension Provide All Registered Extensions Consolidation through InstallExtensions Hook into Nectar Models through NectarExtender Hook into Nectar Router through Nectar.RouteExtender
Removed "/" route pointing to Page Controller to reach out to Nectar Router Home Added nectar app as umbrella dependency to user_app commented Endpoint supervisor as only want to start Repo and other workers Add nectar in applications to start Nectar Repo
…tensionsManager name Added Favourite Products NectarExtension to extend Product & User Added favorite_products app as umbrella dependency to extensions_manager Added favorite_products app as umbrella dependency to user_app Registered Product and User Extension in ExtensionsManager.ExtendProduct and ExtensionsManager.Extenduser present in install_extensions.ex Added UserLike Model under favorite_products Added UserLike Migration for favorite_products Updated Nectar and FavoriteProducts Repo to easily migrate the DB with changes Changed UserApp Repo DB name to be different than Nectar and Favourite Products to highlight any dependency on it
Registered Favourite Products Route Extension in ExtensionsManager.Router present in install_extensions.ex Updated ExtensionsManager.Router in Nectar.RouteExtender to register ExtensionRoutes in Nectar.Router Added Dummy Route in FavoriteProducts.Router to use favorite_path Route Helper [Hack] Added Favourites Index Page to show Favorited Products and List of Products to Favorite Added Mark / Unmark a Product as Favourite
|
|
||
| defmacro include_methods do | ||
| quote do | ||
| unquote(Enum.map(method_blocks, fn (method_block) -> method_block end)) |
There was a problem hiding this comment.
Why not just unquote(method_blocks)? The map doesn't look like it makes any effect on the data...
There was a problem hiding this comment.
Thanks for pointing this out, yes it can be safely removed with no impact. 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.