Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add ruff #2292

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

add ruff #2292

wants to merge 1 commit into from

Conversation

peidrao
Copy link

@peidrao peidrao commented Dec 30, 2022

What is this Python project?

This is in python library for linter

What's the difference between this Python project and similar ones?

Bar chart with benchmark results

  • 10-100x faster than existing linters
  • Installable via pip
  • hammer_and_wrench pyproject.toml support
  • Native re-implementations of popular Flake8 plugins, like flake8-bugbear
  • Monorepo-friendly configuration via hierarchical and cascading settings

--

Anyone who agrees with this pull request could submit an Approve review to it.

@Alao-legalboy
Copy link

Alao-legalboy commented Dec 31, 2022 via email

Copy link

@elkarouani elkarouani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice one

@bowmanjd
Copy link

👍

@peidrao peidrao mentioned this pull request Feb 25, 2023
@peidrao peidrao force-pushed the master branch 4 times, most recently from 5d5f6f9 to a50a140 Compare February 25, 2023 16:22
@Kub-AT
Copy link

Kub-AT commented May 10, 2023

This should be merge. Great linter.

@Owen-CH-Leung
Copy link

Agree with @Kub-AT . This PR should get merged as Ruff is getting more popular

@grigoryalan
Copy link

👍🏻

@Commando-Brando
Copy link

Bumping this issue, Ruff is my favorite and go to linter it should be featured on here surprised it is not

@bowmanjd
Copy link

bowmanjd commented Oct 12, 2023

Bumping this issue, Ruff is my favorite and go to linter it should be featured on here surprised it is not

Agreed! So... did you approve this PR so we can get enough votes to move it through, @Commando-Brando ?

Anyone who agrees with this pull request could submit an Approve review to it.

@Commando-Brando
Copy link

@bowmanjd didn't read the whole issue, oops, but it has been approved, cheers!

@bowmanjd
Copy link

This should be merge. Great linter.

Agreed! @Kub-AT could you approve the PR (that is what counts as a vote)

@bowmanjd
Copy link

Agree with @Kub-AT . This PR should get merged as Ruff is getting more popular

Yes, indeed! Could you approve the PR, @Owen-CH-Leung, then (approval is what counts as a vote; we need 20 to see ruff make the awesome list)

@peidrao
Copy link
Author

peidrao commented Oct 25, 2023

more 3 likes 🙏

@peidrao
Copy link
Author

peidrao commented Oct 25, 2023

@vinta 20 likes

README.md Outdated Show resolved Hide resolved
@Jamim
Copy link
Contributor

Jamim commented Dec 12, 2023

Thanks for a quick update, @peidrao!
Also, it might be worth considering moving ruff to the Code Formatters section down below.

README.md Outdated Show resolved Hide resolved
@aureliojargas aureliojargas mentioned this pull request May 6, 2024
@lechevalier
Copy link

lechevalier commented May 10, 2024

@peidrao Some conflicts appeared, I imagine this is not the first time.
Also worth mentioning that ruff includes a formatter now - rules are quite similar to black, except it is 100 times faster.

@vinta This PR is 2 years old while ruff popularity is exploding.
How is it not merged yet?

@aureliojargas
Copy link

BTW, in the meantime even the CPython repository started using ruff:

https://github.com/python/cpython/blob/7ac933e2609b2ef9b08ccf9c815b682b0e1ede2a/.pre-commit-config.yaml#L2-L12

@AdrianCert
Copy link

@peidrao can you do a rebase and a squash?

Co-authored-by: Aliaksei Urbanski <aliaksei.urbanski@gmail.com>
@peidrao
Copy link
Author

peidrao commented Jun 2, 2024

@peidrao can you do a rebase and a squash?

I have completed the rebase and squash.

@peidrao
Copy link
Author

peidrao commented Jun 2, 2024

@vinta ready to merge.

@Amri588

This comment has been minimized.

@Amri588
Copy link

Amri588 commented Jun 2, 2024

@vinta ready to merge.

@AdrianCert
Copy link

@peidrao can you do a rebase and a squash?

I have completed the rebase and squash.

@vinta ready to merge

@Amri588
Copy link

Amri588 commented Jun 2, 2024

What is this Python project?

This is in python library for linter

What's the difference between this Python project and similar ones?

Bar chart with benchmark results

  • 10-100x faster than existing linters
  • Installable via pip
  • hammer_and_wrench pyproject.toml support
  • Native re-implementations of popular Flake8 plugins, like flake8-bugbear
  • Monorepo-friendly configuration via hierarchical and cascading settings

--

Anyone who agrees with this pull request could submit an Approve review to it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet