Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#358 - Improved reset framework #359

Open
wants to merge 8 commits into
base: master
Choose a base branch
from

Conversation

vintagepc
Copy link
Owner

Description

Fixes resets not properly resetting peripherals and gives them a chance to (re)set their GPIO states.

Behaviour/ Breaking changes

Quite an invasive change, likely to break a few things where the current behaviour happens to work but is not technically correct....

Linked issues:

@codecov
Copy link

codecov bot commented Mar 7, 2022

Codecov Report

Merging #359 (fb32814) into master (37ba3f8) will increase coverage by 0.02%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #359      +/-   ##
==========================================
+ Coverage   91.45%   91.48%   +0.02%     
==========================================
  Files         167      167              
  Lines        7793     7818      +25     
==========================================
+ Hits         7127     7152      +25     
  Misses        666      666              
Impacted Files Coverage Δ
parts/boards/CW1S.h 100.00% <ø> (ø)
parts/boards/EinsyRambo.cpp 96.50% <ø> (-0.08%) ⬇️
parts/boards/MiniRambo.cpp 98.07% <ø> (-0.04%) ⬇️
parts/components/Button.h 100.00% <ø> (ø)
parts/components/Heater.h 100.00% <ø> (ø)
parts/components/IRSensor.h 100.00% <ø> (ø)
parts/components/PINDA.h 100.00% <ø> (ø)
parts/components/RotaryEncoder.h 100.00% <ø> (ø)
parts/components/SDCard.h 100.00% <ø> (ø)
parts/components/TMC2130.h 100.00% <ø> (ø)
... and 10 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 37ba3f8...fb32814. Read the comment docs.

@vintagepc vintagepc marked this pull request as ready for review March 11, 2022 14:00
@vintagepc vintagepc requested a review from leptun March 11, 2022 14:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Check and fix initial register values after reset
1 participant