Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support f32 and f64 in decay functions #262

Merged
merged 1 commit into from Jan 4, 2024

Conversation

alpoi-x
Copy link
Contributor

@alpoi-x alpoi-x commented Jan 4, 2024

Looks like f32 and f64 were missed from the Function macro defined here

This pr adds the missing float types to the list and adds a test to ensure it is serialised correctly

docs: function score query supports all numeric field types

Copy link
Collaborator

@buinauskas buinauskas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@buinauskas buinauskas merged commit 9d367c2 into vinted:master Jan 4, 2024
1 check passed
@alpoi-x
Copy link
Contributor Author

alpoi-x commented Jan 5, 2024

Any chance of a release? 😅

@buinauskas buinauskas mentioned this pull request Jan 5, 2024
@buinauskas
Copy link
Collaborator

@alpoi-x a pretty big chance of release, I've had a rough start of the year, sorry 😅

@alpoi-x alpoi-x deleted the support-float-decay branch January 7, 2024 00:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants