fix(router): fix method not allowed logic

match.go

@@ -1,8 +1,6 @@
 package router
 
-import (
-	"net/url"
-)
+import "net/url"
 
 // Match matches the given path string againts the register pattern.
 func Match(pat, path string) (url.Values, bool) {

router.go

@@ -224,6 +224,7 @@ func (r *Router) match(method, path string) (url.Values, *Route) {
 	return doMatch(r.Routes["*"], path)
 }
 
+// doMatch is used to match a given path againts the registered routes pool.
 func doMatch(routes []*Route, path string) (url.Values, *Route) {
 	if routes == nil || len(routes) == 0 {
 		return nil, nil
@@ -283,6 +284,8 @@ func (r *Router) HandleHTTP(w http.ResponseWriter, req *http.Request, h http.Han
 	h.ServeHTTP(w, req)
 }
 
+// isMethodNowAllowed is used to verify if the given route doesn't allows
+// the given HTTP request method.
 func (r *Router) isMethodNotAllowed(w http.ResponseWriter, req *http.Request) bool {
 	allowed := make([]string, 0, len(r.Routes))
 	for meth, handlers := range r.Routes {

router_test.go

@@ -49,6 +49,7 @@ func TestRoutingHit(t *testing.T) {
 
 func TestRoutingMethodNotAllowed(t *testing.T) {
 	p := New()
+	p.ForceMethodNotAllowed = true
 
 	var ok bool
 	p.Post("/foo/:name").Handle(http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
@@ -60,9 +61,13 @@ func TestRoutingMethodNotAllowed(t *testing.T) {
 	}))
 
 	r := httptest.NewRecorder()
-	p.HandleHTTP(r, newRequest("GET", "/foo/keith", nil), nil)
+	var final bool
+	p.HandleHTTP(r, newRequest("GET", "/foo/keith", nil), http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
+		final = true
+	}))
 
 	st.Expect(t, ok, false)
+	st.Expect(t, final, false)
 	st.Expect(t, r.Code, http.StatusMethodNotAllowed)
 
 	got := strings.Split(r.Header().Get("Allow"), ", ")
@@ -146,7 +151,12 @@ func TestMethodPatch(t *testing.T) {
 	// issue a GET request to a handler that only supports the PATCH method.
 	res := httptest.NewRecorder()
 	res.Code = http.StatusMethodNotAllowed
-	p.HandleHTTP(res, newRequest("GET", "/foo/bar", nil), nil)
+	var final bool
+	p.HandleHTTP(res, newRequest("GET", "/foo/bar", nil), http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
+		final = true
+	}))
+
+	st.Expect(t, final, true)
 	st.Expect(t, res.Code, http.StatusMethodNotAllowed)
 
 	// Now, test to see if we get a 200 OK from issuing a PATCH request to