Change lines to 1based. #3
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
qfox
requested changes
Nov 7, 2016
| * @param {number} [line=0] - errored line | ||
| * @param {number} [column=0] - errored column | ||
| * @param {number} [line=1] - errored line | ||
| * @param {number} [column=1] - errored column |
There was a problem hiding this comment.
Why? It can be 0:0 by default (as undefined)
| @@ -7,16 +7,16 @@ module.exports = Warnie; | |||
| * @name Warnie | |||
| * @param {string} message - text message of error | |||
| * @param {string} filename - name of file the error belongs | |||
| * @param {number} [line=0] - errored line | |||
| * @param {number} [column=0] - errored column | |||
| * @param {number} [severity=0] - severity of the error, one of [-1, 0, 1, 2] | |||
There was a problem hiding this comment.
Let it be another issue, please?
| this.line = line|0; | ||
| this.column = column|0; | ||
| this.line = line||1; | ||
| this.column = column||1; |
There was a problem hiding this comment.
|0 here used to convert to number, not for default value.
| var pointer = Warnie.renderPointer(Warnie.renderLineNumber(0).length + this.column); | ||
| var result = [ | ||
| renderLine(this.line, lines[this.line]), | ||
| renderLine(humanLine, lines[humanLine]), |
There was a problem hiding this comment.
humanLine is one-based now. Here you need zero-based-line.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #1