Skip to content

Commit

Permalink
Support php 8.2 (#97)
Browse files Browse the repository at this point in the history
  • Loading branch information
eiriksm committed Sep 2, 2022
1 parent 4fb52f4 commit b1e3c17
Show file tree
Hide file tree
Showing 9 changed files with 15 additions and 12 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/main.yml
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ jobs:
uses: actions/setup-node@v1
with:
node-version: ${{ matrix.node }}
- run: docker pull violinist/update-check-runner:7.0-multi-composer-1
- run: docker pull violinist/update-check-runner:8.0-multi-composer-2
- run: npm install
- run: echo "{}" > config.json
- run: npm test
Expand Down
4 changes: 2 additions & 2 deletions built/createJob.js

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

3 changes: 2 additions & 1 deletion built/supportedPhpVersions.js

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion built/supportedPhpVersions.js.map

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions src/createJob.ts
Original file line number Diff line number Diff line change
Expand Up @@ -29,10 +29,10 @@ function createJob (config, job: Job, gitRev) {
data.violinist_revision = gitRev
data.violinist_hostname = config.hostname
if (!data.php_version) {
data.php_version = '7.0'
data.php_version = '8.0'
}
if (!data.composer_version) {
data.composer_version = '1'
data.composer_version = '2'
}
let dockerImage = util.format('violinist/update-check-runner:%s-multi-composer-%s', data.php_version, data.composer_version)
// Of course, if the job is trying to say that the type is different, we might want to also use a different image.
Expand Down
3 changes: 2 additions & 1 deletion src/supportedPhpVersions.ts
Original file line number Diff line number Diff line change
Expand Up @@ -5,5 +5,6 @@ module.exports = [
'7.3',
'7.4',
'8.0',
'8.1'
'8.1',
'8.2'
]
5 changes: 3 additions & 2 deletions test/createcloudjob.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,7 @@ describe('createCloudJob', () => {
})
})

it('Should try to start the images expected', async () => {
it('Should try to start the cloud images expected', async () => {
let { createCloudJob } = proxyquire('../src/createCloudJob', {
'aws-sdk': {
ECS: fakeEcs,
Expand All @@ -72,7 +72,8 @@ describe('createCloudJob', () => {
'7.3': 'violinist-73-composer-',
'7.4': 'violinist-74-composer-',
'8.0': 'violinist-80-composer-',
'8.1': 'violinist-81-composer-'
'8.1': 'violinist-81-composer-',
'8.2': 'violinist-82-composer-',
}
for (const delta in supportedVersions) {
for (const cDelta in composerVersions) {
Expand Down
2 changes: 1 addition & 1 deletion test/createjob.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,7 @@ describe('createJob', () => {
imageStarted = logItem[1]
}
})
imageStarted.should.equal(`violinist/update-check-runner:${php_version}-multi-composer-1`)
imageStarted.should.equal(`violinist/update-check-runner:${php_version}-multi-composer-2`)
should(hasStartMessage).equal(true)
})
return Promise.all(jobs)
Expand Down
2 changes: 1 addition & 1 deletion test/integration/createCloudJob.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ const composerVersions = [1, 2]
const supportedVersions = require("../../src/supportedPhpVersions")


describe('createCloudJob', () => {
describe('createCloudJob integration tests', () => {

it('Should totally have all the images as tasks in AWS', async () => {
const awsconfig = {
Expand Down

0 comments on commit b1e3c17

Please sign in to comment.