Merge pull request #2 from violinist-dev/feat/integration-tests

Feat/integration tests

.gitignore

@@ -1,4 +1,5 @@
 .idea
 composer.lock
+!/tests/assets/projects/*/composer.lock
 vendor
 data

composer.json

@@ -12,6 +12,11 @@
       "Violinist\\SymfonyCloudSecurityChecker\\": "src"
     }
   },
+  "autoload-dev": {
+    "psr-4": {
+      "Violinist\\SymfonyCloudSecurityChecker\\Tests\\": "tests"
+    }
+  },
   "require": {
     "symfony/process": "^2.7 || ^3.0 || ^4.0"
   },

phpunit.xml.dist

@@ -12,6 +12,7 @@
     <testsuites>
         <testsuite name="Cloud checker Test Suite">
             <directory>tests/Unit</directory>
+            <directory>tests/Integration</directory>
         </testsuite>
     </testsuites>
     <logging>

src/SecurityChecker.php

@@ -6,6 +6,9 @@
 
 class SecurityChecker
 {
+
+    protected $symfonyCommand = 'symfony';
+
     protected $processFactory;
 
     public function checkDirectory($dir)
@@ -21,7 +24,7 @@ public function checkDirectory($dir)
             $process = $this->getProcess($command);
             $process->run();
         }
-        $command = sprintf('symfony security:check --dir=%s --format=json', $dir);
+        $command = sprintf('%s security:check --dir=%s --format=json', $this->symfonyCommand, $dir);
         $process = $this->getProcess($command);
         $process->run();
         $string = $process->getOutput();

tests/Integration/IntegrationTest.php

@@ -0,0 +1,23 @@
+<?php
+
+namespace Violinist\SymfonyCloudSecurityChecker\Tests\Integration;
+
+use PHPUnit\Framework\TestCase;
+
+class IntegrationTest extends TestCase
+{
+    public function testInsecure()
+    {
+        $checker = new TestSecurityChecker();
+        $result = $checker->checkDirectory(__DIR__ . '/../assets/projects/unsecure');
+        $this->assertTrue(count($result) > 0);
+        $this->assertEquals('CVE-2010-4879', $result["dompdf/dompdf"]["advisories"][0]["cve"]);
+    }
+
+    public function testSecure()
+    {
+        $checker = new TestSecurityChecker();
+        $result = $checker->checkDirectory(__DIR__ . '/../assets/projects/secure');
+        $this->assertTrue(count($result) === 0);
+    }
+}

tests/Integration/TestSecurityChecker.php

@@ -0,0 +1,14 @@
+<?php
+
+namespace Violinist\SymfonyCloudSecurityChecker\Tests\Integration;
+
+use Violinist\SymfonyCloudSecurityChecker\SecurityChecker;
+
+class TestSecurityChecker extends SecurityChecker
+{
+    public function __construct()
+    {
+        $os = strtolower(PHP_OS);
+        $this->symfonyCommand = __DIR__ . '/../assets/bin/symfony-' . $os;
+    }
+}