Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add new config option allow_security_updates_on_concurrent_limit #28

Merged
merged 2 commits into from
Jul 17, 2024

Conversation

truls1502
Copy link
Contributor

Why

We want to get security packages passed on number_of_concurrent_updates by default. But for those who want to save CI minutes or not doing it can feel free disable the skip_security_updates_on_concurrent_limit

@truls1502 truls1502 force-pushed the feat/security-bypass-concurrent branch 2 times, most recently from 2dcdd27 to 96996d5 Compare June 29, 2024 17:51
Copy link
Member

@eiriksm eiriksm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Completely amazing, thanks 🙏♥️

Just a small change and should be good to go. Tests and everything looks great!

src/Config.php Outdated Show resolved Hide resolved
src/Config.php Outdated Show resolved Hide resolved
@truls1502 truls1502 changed the title feat: Add new config parameter skip_security_updates_on_concurrent_limit feat: Add new config option allow_security_updates_on_concurrent_limit Jun 29, 2024
@truls1502 truls1502 force-pushed the feat/security-bypass-concurrent branch 2 times, most recently from 8d5fe2a to dd534c8 Compare June 29, 2024 21:43
src/Config.php Outdated Show resolved Hide resolved
@truls1502 truls1502 force-pushed the feat/security-bypass-concurrent branch from dd534c8 to 18a011b Compare July 17, 2024 19:19
@eiriksm eiriksm merged commit 1807f15 into violinist-dev:main Jul 17, 2024
8 checks passed
@eiriksm
Copy link
Member

eiriksm commented Jul 17, 2024

Awesome thanks 🙏

@truls1502 truls1502 deleted the feat/security-bypass-concurrent branch July 17, 2024 20:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants