Replicate behaviour from rails-api to not create edit/new routes on a…

…pi apps by default, to mimic behaviour from controllers. See also rails-api/rails-api@41f949f Fixes rails#24573
vipulnsward · Apr 20, 2016 · 8671dbd · 8671dbd
1 parent 697384d
commit 8671dbd
Show file tree

Hide file tree

Showing 3 changed files with 9 additions and 3 deletions.
diff --git a/railties/lib/rails/generators/rails/resource_route/resource_route_generator.rb b/railties/lib/rails/generators/rails/resource_route/resource_route_generator.rb
@@ -1,6 +1,10 @@
 module Rails
   module Generators
     class ResourceRouteGenerator < NamedBase # :nodoc:
+
+      class_option :api, type: :boolean,
+                   desc: "Preconfigure smaller stack for API only apps"
+
       # Properly nests namespaces passed into a generator
       #
       #   $ rails generate resource admin/users/products
@@ -21,7 +25,9 @@ def add_resource_route
         end
 
         # inserts the primary resource
-        write("resources :#{file_name.pluralize}", route_length + 1)
+        resource_string = "resources :#{file_name.pluralize}"
+        resource_string << ", except: [:new, :edit]" if options.api?
+        write(resource_string, route_length + 1)
 
         # ends blocks
         regular_class_path.each_index do |index|

diff --git a/railties/test/generators/namespaced_generators_test.rb b/railties/test/generators/namespaced_generators_test.rb
@@ -409,7 +409,7 @@ def test_api_scaffold_with_namespace_on_invoke
 
     # Route
     assert_file "config/routes.rb" do |route|
-      assert_match(/^  namespace :admin do\n    resources :roles\n  end$/, route)
+      assert_match(/^  namespace :admin do\n    resources :roles, except: \[:new, :edit\]\n  end$/, route)
     end
 
     # Controller

diff --git a/railties/test/generators/scaffold_generator_test.rb b/railties/test/generators/scaffold_generator_test.rb
@@ -99,7 +99,7 @@ def test_api_scaffold_on_invoke
 
     # Route
     assert_file "config/routes.rb" do |route|
-      assert_match(/resources :product_lines$/, route)
+      assert_match(/resources :product_lines, except: \[:new, :edit\]$/, route)
     end
 
     # Controller