First exchange of Vircadia protocol packets with the Vircadia Web SDK. #1259

ctrlaltdavid · 2021-06-26T10:57:37Z

This PR in conjunction with Vircadia-Web-SDK PR vircadia/vircadia-web-sdk#9 implements the first exchange of Vircadia protocol packets with the domain server.

Merge sequence:

Vircadia PR: Implement WebRTC Data Channel. #1238
Update this PR with the latest webapp branch.
Vircadia-Web-SDK PR: First exchange of Vircadia protocol packets with the Domain server. vircadia-web-sdk#9
Update Vircadia-Web repo to use the latest Vircadia-Web-SDK.
Update this PR to use the latest Vircadia-Web master branch.
CR, QA.
Merge this PR.

vircadia-build-notifier · 2021-06-26T12:48:45Z

The following links are available:
build (macOS-latest, client)

https://athena-public.s3.eu-west-3.amazonaws.com/builds/PR/vircadia_vircadia/PR1259/Vircadia-Interface-PR1259-1aa1f87-_2a9ab98e.dmg

build (macOS-latest, full)

https://athena-public.s3.eu-west-3.amazonaws.com/builds/PR/vircadia_vircadia/PR1259/Vircadia-PR1259-1aa1f87-_2a9ab98e.dmg

build (ubuntu-18.04, full)

build (windows-latest, full)

https://athena-public.s3.eu-west-3.amazonaws.com/builds/PR/vircadia_vircadia/PR1259/Vircadia-PR1259-1aa1f87-_2a9ab98e.exe

vircadia-build-notifier · 2021-07-01T03:25:40Z

The following links are available:
build (ubuntu-18.04, full)

build (macOS-latest, client)

https://athena-public.s3.eu-west-3.amazonaws.com/builds/PR/vircadia_vircadia/PR1259/Vircadia-Interface-PR1259-544c6f9-_4d375c02.dmg

build (macOS-latest, full)

https://athena-public.s3.eu-west-3.amazonaws.com/builds/PR/vircadia_vircadia/PR1259/Vircadia-PR1259-544c6f9-_4d375c02.dmg

build (windows-latest, full)

https://athena-public.s3.eu-west-3.amazonaws.com/builds/PR/vircadia_vircadia/PR1259/Vircadia-PR1259-544c6f9-_4d375c02.exe

vircadia-build-notifier · 2021-07-01T09:00:03Z

The following links are available:
build (ubuntu-18.04, full)

build (macOS-latest, client)

https://athena-public.s3.eu-west-3.amazonaws.com/builds/PR/vircadia_vircadia/PR1259/Vircadia-Interface-PR1259-040906e-_b7fdd5bb.dmg

build (macOS-latest, full)

https://athena-public.s3.eu-west-3.amazonaws.com/builds/PR/vircadia_vircadia/PR1259/Vircadia-PR1259-040906e-_b7fdd5bb.dmg

build (windows-latest, full)

https://athena-public.s3.eu-west-3.amazonaws.com/builds/PR/vircadia_vircadia/PR1259/Vircadia-PR1259-040906e-_b7fdd5bb.exe

libraries/networking/src/AddressManager.h

libraries/networking/src/LimitedNodeList.cpp

daleglass · 2021-07-01T20:16:55Z

libraries/networking/src/udt/NetworkSocket.cpp

+    case SocketType::UDP:
+        // WEBRTC TODO: The Qt documentation says that the following call shouldn't be used if the UDP socket is connected!!!
+        // https://doc.qt.io/qt-5/qudpsocket.html#writeDatagram
+        return _udpSocket.writeDatagram(datagram, sockAddr.getAddress(), sockAddr.getPort());


Why use writeDatagram anyway, against the recommendation, then? It seems easy to call write here as recommended.

This is the way it's currently done in master for UDP packets and should be addressed there rather than here.
#1279

daleglass · 2021-07-01T20:19:34Z

libraries/networking/src/udt/NetworkSocket.h

+
+
+/// @brief Multiplexes a QUdpSocket and a WebRTCSocket so that they appear as a single QUdpSocket-style socket.
+class NetworkSocket : public QObject {


perhaps this should inherit from QAbstractSocket instead?

QAbstractSocket inherits from QIODevice and no code from either of these is needed. It's not clear to me whether inheriting from QAbstractSocket would be beneficial or just overhead and a potential source of problems.

daleglass · 2021-07-01T20:22:12Z

libraries/networking/src/webrtc/WebRTCSocket.h

+
+
+/// @brief Provides a QUdpSocket-style interface for using WebRTCDataChannels.
+class WebRTCSocket : public QObject {


Perhaps it should inherit from QAbstractSocket?

tools/doxygen/Doxyfile

tools/doxygen/README.md

vircadia-build-notifier · 2021-07-01T23:36:45Z

The following links are available:
build (ubuntu-18.04, full)

build (macOS-latest, client)

https://athena-public.s3.eu-west-3.amazonaws.com/builds/PR/vircadia_vircadia/PR1259/Vircadia-Interface-PR1259-040906e-_b7fdd5bb.dmg

build (macOS-latest, full)

https://athena-public.s3.eu-west-3.amazonaws.com/builds/PR/vircadia_vircadia/PR1259/Vircadia-PR1259-040906e-_b7fdd5bb.dmg

build (windows-latest, full)

https://athena-public.s3.eu-west-3.amazonaws.com/builds/PR/vircadia_vircadia/PR1259/Vircadia-PR1259-040906e-_b7fdd5bb.exe

vircadia-build-notifier · 2021-07-02T01:57:06Z

The following links are available:
build (ubuntu-18.04, full)

build (macOS-latest, client)

https://athena-public.s3.eu-west-3.amazonaws.com/builds/PR/vircadia_vircadia/PR1259/Vircadia-Interface-PR1259-1af8c0b-_f02ffe1e.dmg

build (macOS-latest, full)

https://athena-public.s3.eu-west-3.amazonaws.com/builds/PR/vircadia_vircadia/PR1259/Vircadia-PR1259-1af8c0b-_f02ffe1e.dmg

build (windows-latest, full)

https://athena-public.s3.eu-west-3.amazonaws.com/builds/PR/vircadia_vircadia/PR1259/Vircadia-PR1259-1af8c0b-_f02ffe1e.exe

build (ubuntu-18.04, android)

vircadia-build-notifier · 2021-07-05T01:07:31Z

The following links are available:
build (macOS-latest, client)

https://athena-public.s3.eu-west-3.amazonaws.com/builds/PR/vircadia_vircadia/PR1259/Vircadia-Interface-PR1259-0e3627e-_28b46ed8.dmg

build (macOS-latest, full)

https://athena-public.s3.eu-west-3.amazonaws.com/builds/PR/vircadia_vircadia/PR1259/Vircadia-PR1259-0e3627e-_28b46ed8.dmg

build (ubuntu-18.04, full)

build (ubuntu-18.04, android)

vircadia-build-notifier · 2021-07-05T09:23:54Z

The following links are available:
build (ubuntu-18.04, full)

build (macOS-latest, full)

https://athena-public.s3.eu-west-3.amazonaws.com/builds/PR/vircadia_vircadia/PR1259/Vircadia-PR1259-0e3627e-_28b46ed8.dmg

build (macOS-latest, client)

https://athena-public.s3.eu-west-3.amazonaws.com/builds/PR/vircadia_vircadia/PR1259/Vircadia-Interface-PR1259-0e3627e-_28b46ed8.dmg

build (ubuntu-18.04, android)

build (windows-latest, full)

https://athena-public.s3.eu-west-3.amazonaws.com/builds/PR/vircadia_vircadia/PR1259/Vircadia-PR1259-0e3627e-_28b46ed8.exe

# Conflicts: # libraries/networking/src/webrtc/WebRTCDataChannels.h

vircadia-build-notifier · 2021-07-08T05:43:20Z

The following links are available:
build (macOS-latest, client)

https://athena-public.s3.eu-west-3.amazonaws.com/builds/PR/vircadia_vircadia/PR1259/Vircadia-Interface-PR1259-c8c06b0-_837f2e06.dmg

build (ubuntu-18.04, full)

build (windows-latest, full)

https://athena-public.s3.eu-west-3.amazonaws.com/builds/PR/vircadia_vircadia/PR1259/Vircadia-PR1259-c8c06b0-_837f2e06.exe

build (ubuntu-18.04, android)

vircadia-build-notifier · 2021-07-08T10:36:35Z

The following links are available:
build (ubuntu-18.04, full)

build (macOS-latest, client)

https://athena-public.s3.eu-west-3.amazonaws.com/builds/PR/vircadia_vircadia/PR1259/Vircadia-Interface-PR1259-c8c06b0-_837f2e06.dmg

build (macOS-latest, full)

https://athena-public.s3.eu-west-3.amazonaws.com/builds/PR/vircadia_vircadia/PR1259/Vircadia-PR1259-c8c06b0-_837f2e06.dmg

build (windows-latest, full)

https://athena-public.s3.eu-west-3.amazonaws.com/builds/PR/vircadia_vircadia/PR1259/Vircadia-PR1259-c8c06b0-_837f2e06.exe

build (ubuntu-18.04, android)

digisomni

Worked fine according to the unit tests on master of the Vircadia Web SDK as of 7/15/2021.

ctrlaltdavid added 5 commits June 26, 2021 17:23

Remove unused code

c9d4fe8

WebRTCSignalingServer and WebRTCDataChannels improvements

5b937a1

Abstract WebRTCDataChannel into a QUdpSocket-style WebRTCSocket

d65ecea

Multiplex UDP and WebRTC sockets in a QUdpSocket-style NetworkSocket

5a5cb64

Miscellaneous tidying and fixes

2a9ab98

ctrlaltdavid mentioned this pull request Jun 26, 2021

First exchange of Vircadia protocol packets with the Domain server. vircadia/vircadia-web-sdk#9

Merged

3 tasks

ctrlaltdavid added 2 commits June 30, 2021 22:21

Tidying

d0c89c7

Merge remote-tracking branch 'upstream/webapp' into dev/webrtc-packet

4d375c0

ctrlaltdavid marked this pull request as ready for review July 1, 2021 01:31

ctrlaltdavid added enhancement New feature or request needs CR (code review) needs testing (QA) The PR is ready for testing labels Jul 1, 2021

Remove extraneous Doxygen set-up instruction

b7fdd5b

daleglass suggested changes Jul 1, 2021

View reviewed changes

Use alternative signal/slot mechanism for Android compatibility

f02ffe1

ctrlaltdavid added 2 commits July 5, 2021 10:24

Undo documentation improvements

3ebb75a

Log warning if try to set local port on WebRTC LimitedNodeList

28b46ed

ctrlaltdavid requested a review from daleglass July 4, 2021 23:22

digisomni added this to Review in progress in Web Part 1: Interface + SDK - May through October 2021 Jul 5, 2021

digisomni added the web sdk Related to the Vircadia Web SDK label Jul 5, 2021

ctrlaltdavid added 3 commits July 8, 2021 14:54

Merge branch 'webapp' into dev/webrtc-packet

ed13cbd

# Conflicts: # libraries/networking/src/webrtc/WebRTCDataChannels.h

Fix build error

4dac611

Update to latest Vircadia Web

837f2e0

digisomni self-requested a review July 8, 2021 21:36

Web Part 1: Interface + SDK - May through October 2021 automation moved this from Review in progress to Reviewer approved Jul 13, 2021

daleglass approved these changes Jul 13, 2021

View reviewed changes

digisomni added CR Approved At least one code reviewer has approved the PR. and removed needs CR (code review) labels Jul 15, 2021

digisomni approved these changes Jul 16, 2021

View reviewed changes

digisomni merged commit dfd71ab into vircadia:webapp Jul 16, 2021

Web Part 1: Interface + SDK - May through October 2021 automation moved this from Reviewer approved to Done Jul 16, 2021

ctrlaltdavid deleted the dev/webrtc-packet branch July 21, 2021 00:08

digisomni added the unmerged-dev A project being developed in parallel to master, to be merged at a later date. label Sep 7, 2021

digisomni changed the title ~~First exchange of Vircadia protocol packets with the Vircadia Web SDK~~ First exchange of Vircadia protocol packets with the Vircadia Web SDK. Sep 7, 2021

digisomni added QA Approved The PR has been tested successfully. and removed needs testing (QA) The PR is ready for testing enhancement New feature or request labels Sep 7, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

First exchange of Vircadia protocol packets with the Vircadia Web SDK. #1259

First exchange of Vircadia protocol packets with the Vircadia Web SDK. #1259

ctrlaltdavid commented Jun 26, 2021 •

edited by digisomni

vircadia-build-notifier commented Jun 26, 2021

vircadia-build-notifier commented Jul 1, 2021

vircadia-build-notifier commented Jul 1, 2021

daleglass Jul 1, 2021

ctrlaltdavid Jul 4, 2021

daleglass Jul 1, 2021

ctrlaltdavid Jul 4, 2021

daleglass Jul 1, 2021

ctrlaltdavid Jul 4, 2021

vircadia-build-notifier commented Jul 1, 2021

vircadia-build-notifier commented Jul 2, 2021

vircadia-build-notifier commented Jul 5, 2021

vircadia-build-notifier commented Jul 5, 2021

vircadia-build-notifier commented Jul 8, 2021

vircadia-build-notifier commented Jul 8, 2021

digisomni left a comment



		/// @brief Multiplexes a QUdpSocket and a WebRTCSocket so that they appear as a single QUdpSocket-style socket.
		class NetworkSocket : public QObject {



		/// @brief Provides a QUdpSocket-style interface for using WebRTCDataChannels.
		class WebRTCSocket : public QObject {

First exchange of Vircadia protocol packets with the Vircadia Web SDK. #1259

First exchange of Vircadia protocol packets with the Vircadia Web SDK. #1259

Conversation

ctrlaltdavid commented Jun 26, 2021 • edited by digisomni

vircadia-build-notifier commented Jun 26, 2021

vircadia-build-notifier commented Jul 1, 2021

vircadia-build-notifier commented Jul 1, 2021

daleglass Jul 1, 2021

Choose a reason for hiding this comment

ctrlaltdavid Jul 4, 2021

Choose a reason for hiding this comment

daleglass Jul 1, 2021

Choose a reason for hiding this comment

ctrlaltdavid Jul 4, 2021

Choose a reason for hiding this comment

daleglass Jul 1, 2021

Choose a reason for hiding this comment

ctrlaltdavid Jul 4, 2021

Choose a reason for hiding this comment

vircadia-build-notifier commented Jul 1, 2021

vircadia-build-notifier commented Jul 2, 2021

vircadia-build-notifier commented Jul 5, 2021

vircadia-build-notifier commented Jul 5, 2021

vircadia-build-notifier commented Jul 8, 2021

vircadia-build-notifier commented Jul 8, 2021

digisomni left a comment

Choose a reason for hiding this comment

ctrlaltdavid commented Jun 26, 2021 •

edited by digisomni