Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

First exchange of Vircadia protocol packets with the Domain server. #9

Merged
merged 25 commits into from
Jul 8, 2021
Merged

First exchange of Vircadia protocol packets with the Domain server. #9

merged 25 commits into from
Jul 8, 2021

Conversation

ctrlaltdavid
Copy link
Collaborator

@ctrlaltdavid ctrlaltdavid commented Jun 19, 2021 •
edited
Loading

This PR in conjunction with Vircadia PR vircadia/vircadia-native-core#1259 implements the first exchange of Vircadia protocol packets with the domain server:

  • The Vircadia Web SDK sends a DomainConnectRequest to the domain server.
  • The domain server responds with a DomainList packet.

This exchange is tested in Nodeslist.integration.test.js.

PR development status:

  • Vircadia Web SDK: Send and receive protocol packets using the WebRTC data channel directly.
  • Vircadia: In the domain server, wrap WebRTC data channels in a QUdpSocket-style interface and use in parallel with the current native QUdpSocket.
  • Vircadia Web SDK: Wrap WebRTC data channels in higher level classes in preparation for use by the rest of the SDK and communications with assignment clients.

Merge sequence: This PR can be merged when ready.

@ctrlaltdavid ctrlaltdavid marked this pull request as draft June 19, 2021 11:19
@ctrlaltdavid ctrlaltdavid mentioned this pull request Jun 26, 2021
Merged
7 tasks
@ctrlaltdavid ctrlaltdavid marked this pull request as ready for review July 1, 2021 00:00
@digisomni digisomni self-requested a review July 1, 2021 21:29
@digisomni digisomni moved this from Review in progress to In progress in Web Part 1: Interface + SDK - May through October 2021 Jul 5, 2021
@digisomni digisomni moved this from In progress to Review in progress in Web Part 1: Interface + SDK - May through October 2021 Jul 5, 2021
digisomni
digisomni requested changes Jul 6, 2021
View reviewed changes
src/libraries/networking/FingerprintUtils.js Show resolved Hide resolved
src/libraries/networking/LimitedNodeList.js Show resolved Hide resolved
src/libraries/networking/NLPacket.js Show resolved Hide resolved
src/libraries/networking/ReceivedMessage.js Outdated Show resolved Hide resolved
src/libraries/networking/packets/DomainConnectRequest.js Outdated Show resolved Hide resolved
tests/libraries/shared/Uuid.unit.test.js Show resolved Hide resolved
tests/libraries/networking/packets/PacketData.unit.test.js Outdated Show resolved Hide resolved
tests/libraries/networking/NodesList.integration.test.js Outdated Show resolved Hide resolved
tests/libraries/networking/DomainHandler.integration.test.js Outdated Show resolved Hide resolved
tests/libraries/networking/AddressManager.integration.test.js Outdated Show resolved Hide resolved
@ctrlaltdavid ctrlaltdavid linked an issue Jul 6, 2021 that may be closed by this pull request
Retrieve server info from config for unit tests #11
Closed
Web Part 1: Interface + SDK - May through October 2021 automation moved this from Review in progress to Reviewer approved Jul 6, 2021
@digisomni digisomni added CR approved At least one code reviewer has approved the PR and removed needs CR (code review) labels Jul 6, 2021
@ctrlaltdavid ctrlaltdavid added needs CR (code review) and removed CR approved At least one code reviewer has approved the PR labels Jul 7, 2021
@digisomni digisomni added CR approved At least one code reviewer has approved the PR QA approved Has been tested successfully and removed needs CR (code review) needs QA (testing) labels Jul 7, 2021
@digisomni digisomni merged commit ba8a9eb into vircadia:master Jul 8, 2021
Web Part 1: Interface + SDK - May through October 2021 automation moved this from Reviewer approved to Done Jul 8, 2021
@ctrlaltdavid ctrlaltdavid deleted the dev/webrtc-packet branch July 8, 2021 02:27
@digisomni digisomni changed the title First exchange of Vircadia protocol packets with the domain server First exchange of Vircadia protocol packets with the Domain server. Sep 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@digisomni digisomni digisomni approved these changes

Assignees
No one assigned
Labels
CR approved At least one code reviewer has approved the PR enhancement New feature or request QA approved Has been tested successfully
Projects
No open projects
Web Part 1: Interface + SDK - May thr...
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Retrieve server info from config for unit tests
2 participants
@ctrlaltdavid @digisomni