-
Notifications
You must be signed in to change notification settings - Fork 174
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/set avatar bookmark icons #749
Open
two-one-five
wants to merge
2
commits into
master
Choose a base branch
from
feature/set-avatar-bookmark-icons
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The commit history looks like this needs a rebase |
The following links are available: build (ubuntu-18.04, full)
build (windows-latest, full) |
@kasenvr What's the state of this one? Still needs work? |
Hello! Is this still an issue? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
enhancement
New feature or request
postponed
This will be revisited at a later time.
stale
Issue / PR has not had activity
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a work-in-progress... still some issues such as the icon for the active bookmark not using this (easy fix) to the default icon not showing when you don't set a URL which is an empty string "".
Also
AvatarApp.qml:97:5: Unable to assign [undefined] to QString
shows but unsure if that started when I adjusted things or not.Avatar App should work this way.... Try the Bookmarks.json to see if there's an icon defined there, if not, try the .fst to see if there's an icon there, if not, try the filesystem next to the avatar to see if there's an icon there, if not, just show the default icon for avatars when there is no icon found.
What this PR does: It allows you to set an icon for an avatar directly using avatar bookmarks.