Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add MyAvatar scale and targetScale. #116

Merged
merged 4 commits into from
Jun 20, 2022
Merged

Add MyAvatar scale and targetScale. #116

merged 4 commits into from
Jun 20, 2022

Conversation

ctrlaltdavid
Copy link
Collaborator

  • Send own avatar target scale to avatar mixer.
  • Provide own avatar target scale in API.
  • Provide domain server limited avatar scale in API.
  • Simplify MyAvatar, Avatar, and AvatarData internal APIs.

Note: Domain server avatar limits are per domain server defaults until DomainSettings packet is handled - #114.

@ctrlaltdavid ctrlaltdavid added the enhancement New feature or request label Jun 19, 2022
@ctrlaltdavid ctrlaltdavid mentioned this pull request Jun 19, 2022
Closed
13 tasks
julien-me
julien-me approved these changes Jun 20, 2022
View reviewed changes
Copy link
Contributor

@julien-me julien-me left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ran tests, lint. Built. Ran example app.

All looks good.

@ctrlaltdavid ctrlaltdavid merged commit 7be05b2 into vircadia:master Jun 20, 2022
@ctrlaltdavid ctrlaltdavid changed the title Add MyAvatar scale and targetScale Add MyAvatar scale and targetScale. Jun 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@julien-me julien-me julien-me approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ctrlaltdavid @julien-me