Skip to content

Commit

Permalink
installer: Prefer xorrisofs over genisoimage/mkisofs
Browse files Browse the repository at this point in the history
Apparently it's the most likely version to exist in distros these
days. Particularly the other options may not be shipped in stock
RHEL9

Signed-off-by: Cole Robinson <crobinso@redhat.com>
  • Loading branch information
crobinso committed May 22, 2021
1 parent b891018 commit 3785abc
Showing 1 changed file with 6 additions and 4 deletions.
10 changes: 6 additions & 4 deletions virtinst/install/installerinject.py
Expand Up @@ -45,10 +45,12 @@ def _run_initrd_commands(initrd, tempdir):


def _run_iso_commands(iso, tempdir, cloudinit=False):
# Some distros do not link mkisofs to genisoimage (or vice-versa). As a
# result of this, we have to actually check for both programs and use the
# most appropriate one.
programs = ["genisoimage", "mkisofs"]
# These three programs all behave similarly for our needs, and
# different distros only have some available. xorriso is apparently
# the actively maintained variant that should be available everywhere
# and without any license issues. Some more info here:
# https://wiki.debian.org/genisoimage
programs = ["xorrisofs", "genisoimage", "mkisofs"]
for program in programs:
if shutil.which(program):
break
Expand Down

0 comments on commit 3785abc

Please sign in to comment.