fix: ensure docker config auth deserialized to username/password #171
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gossion
added a commit
to gossion/AgentBaker
that referenced
this pull request
Nov 4, 2021
1.4.1 has [fix](virtual-kubelet/azure-aci#171) to ensure docker config auth deserialized to username/password
andyliuliming
added a commit
to Azure/AgentBaker
that referenced
this pull request
Nov 5, 2021
* add virtual-kubelet 1.4.1 into VHD 1.4.1 has [fix](virtual-kubelet/azure-aci#171) to ensure docker config auth deserialized to username/password * rm 1.3.6 Co-authored-by: Liming Liu <andyliuliming@outlook.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When decoupling vk from kubernetes repo, the docker config auth was not deserialized because the data structure has been moved to azure-aci repo.
This PR fixes the issue by adding auth deserializaiton.