Jplayer preload #540
Merged
Jplayer preload #540
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Not sure what this PR is doing. Looks like there are some setHeading calls for the rover - maybe because it needs a rebase? Also, looks like most of the code that might actually do something is commented out. Is there a corresponding VWF-side PR? |
|
Ahhh, read the comment now. This is fine to check in, I guess - but the job is only half done. Each scenario should specify which cutscene to have preloaded, and then this functionality should be used to make that happen. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Modified
videoController.jsto support the changes made in #489. Also added (commented out) code inscenario_dummyfor testing of the preloading functionality.Depends on #489.