Branch/jplayer preload #489
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| if( node.url ) { | ||
| node.jPlayerElement.jPlayer( "play" ); | ||
| } else { | ||
| this.logger.errorx( "No URL given!" ); |
There was a problem hiding this comment.
Should play require a URL? Doesn't it just play the video that was previously set using the load command?
There was a problem hiding this comment.
The load command does not set the URL. I'm following the convention that JPlayer uses - you set the URL first (With our driver, it's a set of the url property. With JPlayer, it's in the setMedia command), and the load method tells it to preload what was at the previously-set URL.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Separated URL from the "Play" method (this matches the old jPlayer driver), and also added a wrapper for the "load" function (which preloads video).