Fix HUD Event Disabling #520
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@kadst43 @AmbientOSX
So, remember how I said I didn't remember disabling the camera when the HUD was disabled? Well, I was right, sort of. I accidentally referenced the
typevariable out of scope in the code that I changed here, which caused the else condition to fail. What it should do, and what it now does, is when the HUD is disabled, it uses the default event of the game canvas, which is navigation.This is just one of those things that broke quietly and because it resulted in a change we thought we wanted, it never drew any attention. A happy/unhappy coincidence.
Just to be perfectly clear, this change re-enables the camera movement during mission VO.