Additional fixes to the solo game dashboard layout #896
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
on the server we now keep track of round events by an inPlay flag on the full deck instead of a seperate array. the full list (or just the round events) are given to the client via state.visibleEventCards so the card properties can be updated the client has access to inPlay and expired and will automatically scroll to the new round cards when it changes on a new round TODO: style events
- cap the dashboard size at 1200x700 so we can tweak the ui for all reasonable screen sizes (centered) - reformat event thresholds - other minor tweaks to make things appear more coherent and reduce overflow when undesirable
better indication of whats happening during the round transition, including a little pop-up indicator of how much system health was gained event modals now close and reopen when we go to a new event card to better visually indicate the change, especially for events that appear the same
- fix prop mutation warning on the modal.visible prop
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.