Perl Critic friendly

virtualmin · Apr 19, 2017 · 8938392 · 8938392
1 parent 1e3e51a
commit 8938392
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 2 deletions.
diff --git a/lib/Virtualmin/Config/Plugin/PostgreSQL.pm b/lib/Virtualmin/Config/Plugin/PostgreSQL.pm
@@ -31,13 +31,14 @@ sub actions {
 
   if (foreign_check("postgresql")) {
     $self->spin();
+    my $err; # We should handle errors better here.
 		foreign_require("postgresql", "postgresql-lib.pl");
 		if (!-r $postgresql::config{'hba_conf'}) {
 			# Needs to be initialized
-			my $err = postgresql::setup_postgresql();
+			$err = postgresql::setup_postgresql();
 		}
 		if (postgresql::is_postgresql_running() == 0) {
-			my $err = postgresql::start_postgresql();
+			$err = postgresql::start_postgresql();
 		}
     if ($err) { $self->done(0); } # Something went wrong
     else { $self->done(1); } # OK!

diff --git a/t/data/etc/webmin/miniserv.conf b/t/data/etc/webmin/miniserv.conf
@@ -44,3 +44,4 @@ login_script=/etc/webmin/login.pl
 cipher_list_def=1
 logout_script=/etc/webmin/logout.pl
 webprefix=
+theme=dummy-theme