Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Elasticsearch: If zero indices need refreshing don't call refresh on flush #314

Merged
merged 1 commit into from
Oct 9, 2018

Conversation

joeferner
Copy link
Contributor

No description provided.

Copy link
Contributor

@mwizeman mwizeman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There seems to be a test failing in the es5-multimodule-test profile. I kicked off Travis a couple of times to see if it was some kind of timing problem but it appears to be consistent.

@joeferner
Copy link
Contributor Author

Well that stinks. If I run all the es5-multimodule-test tests locally I get a failure right here https://github.com/visallo/vertexium/blob/master/test/src/main/java/org/vertexium/test/GraphTestBase.java#L3112 but when I run testGraphQueryHasAuthorizationWithHidden by itself I get a pass. If I run testGraphQueryHasAuthorization and testGraphQueryHasAuthorizationWithHidden together I can get a failure. But if I set breakpoints I get a pass.

@joeferner
Copy link
Contributor Author

@mwizeman should be fixed now. Just waiting for CI

@mwizeman mwizeman merged commit f0fafe7 into master Oct 9, 2018
@mwizeman mwizeman deleted the dont-refresh-zero-index branch October 9, 2018 18:51
@visallo visallo deleted a comment from siddhesh23sawant Oct 10, 2018
@visallo visallo deleted a comment from siddhesh23sawant Oct 10, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants