Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ability to make states public #157

Merged
merged 15 commits into from
Aug 13, 2021
Merged

Add ability to make states public #157

merged 15 commits into from
Aug 13, 2021

Conversation

JackWilb
Copy link
Member

Closes #149

Waiting on some frontend changes here and on some testing

@JackWilb
Copy link
Member Author

JackWilb commented Aug 12, 2021

  • Need to add Switch from material ui to creation screen with "public" label
  • Need to update requests for PUT and POST state to use new params

@haihan-lin
Copy link
Collaborator

haihan-lin commented Aug 12, 2021

  • Made the changes.
  • fixed the alerts (I think?). There should be success/failure alert at the bottom of the interface upon clicking confirm.
  • The button also disables if there is no input for state name.

@haihan-lin haihan-lin marked this pull request as ready for review August 12, 2021 22:39
@JackWilb
Copy link
Member Author

JackWilb commented Aug 13, 2021

Things I noticed:

  • no timeout for snack bar (can we add one so it doesn't just persist until closed?
  • making state cleared the states list (on internal server error, works on success)

My TODOs:

  • Test that public states are available to all
  • Test that private states are not available to all

@haihan-lin
Copy link
Collaborator

the snacker timeout is a minute. maybe 5 seconds instead?

@haihan-lin haihan-lin merged commit 413e5f6 into master Aug 13, 2021
@haihan-lin haihan-lin deleted the public-states branch August 13, 2021 19:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow a state to be public
2 participants